[05:00:07] @aguycalled I've checked the PR, and looks good, will read more of the code later and might be able to run some tests [05:04:30] @aguycalled on devnet, created 3 qt nodes, 0 -> 1 -> 2. 2 launched with excludevote. Created a proposal with node 1 and voted yes once. Then used node 2 to generate 9 blcoks (also tried with staking). My expectation was that the proposal will pass since that 1 vote shuold mean 100% while the 9 blocked mined by the excludevote node not counted. But the proposal does not pass. [05:05:03] I am updating the stressor script now so i can stress run it tomorrow just to check that the statehash will match. [05:24:06] https://cdn.discordapp.com/attachments/416000318149754881/765052145686806548/stressor_excludevote.sh [05:40:11] https://cdn.discordapp.com/attachments/416000318149754881/765056196171268156/stressor_dao_excludevote.sh [05:48:57] Question to this pr: 1. If a new proposal arrives, and it will be ignored until it expires. Will this count as 6 cycles inactivity or 1? 2. Are only proposals counted or also consultations? [07:59:54] @Goku if it is ignored and no votes happen at all those cycles are not counted [08:00:05] also consultations [08:23:56] Sorry maybe it sounds stupid, but what is then counted? I mean for the automatic activation of excluding blocks from vote [08:36:02] in my mind that it would mean the excluded nodes when they stake a block, the block is not counted as the 20160 block cycle. [08:36:26] but then when i test the PR, it doesn't seem to work that way [08:39:17] in my mind, if a block cycle has 10 blocks, and if an excluded note staked 3 blocks, the base for that cycle becomes 7 blocks, and the 50% quorum would then mean 3.5 blocks. [08:50:05] Yes is how I see that. But I mean the auto-activation to exclude. 10 cycle need to pass with a proposal. Will one ignored proposal with 6 cycles, counted as 6 ignored cycles? [08:50:34] accumulated i believe [08:50:49] so yes, and then the next one starts with 7 [08:51:00] i haven't tested it though [08:52:23] @salmonskinroll how did you create the proposal? gui or rpc? [08:52:23] nope, if a proposal is ignored and receives no vote from anyone it is not counted [08:52:24] the counter only starts when the first vote in a cycle happens [08:52:51] gui [08:52:58] ok let me try [08:55:26] > the counter only starts when the first vote in a cycle happens @aguycalled What vote? Proposal, payment request, consultation or consensus change? [08:55:44] any [09:31:11] @salmonskinroll it should be fine now [09:31:15] with the last commit [09:31:21] thx for helping to test this! [09:31:51] Sure thing. I'll try it out. [09:54:20] > the counter only starts when the first vote in a cycle happens @aguycalled And get reseted by a vote. What about votes from a voting address? [09:54:59] it would work the same