[11:35:21] same error for gitian windows [11:35:22] https://build.nav.community/binaries/blsct-addict/log/win/ [11:35:25] @mxaddict [12:29:49] hmmmm, I'll check it out [12:33:24] I'm running the gitian build for windows now [12:42:23] @aguycalled seems my build is working [12:42:35] I got past the tor build section already [12:42:39] waiting for it to finish [12:43:16] I ran gitian like so: USE_DOCKER=1 ./bin/gbuild -j24 --commit navcoin-core=blsct-addict --url navcoin-core=git@github.com:mxaddict/navcoin-core.git ../navcoin-core/contrib/gitian-descriptors/gitian-win.yml [12:43:36] I'm using gitian version: bd59d446512b76f37670d40e3e2d52f6a574cc23 [13:35:26] It build successfully for me: --- Building for bionic amd64 --- Stopping target if it is up Making a new image copy Starting target Checking if target is up. Preparing build environment Updating apt-get repository (log in var/install.log) Installing additional packages (log in var/install.log) Upgrading system, may take a while (log in var/install.log) Creating package manifest Creating build script (var/build-script) Running build [13:35:26] script (log in var/build.log) Grabbing results from target Grabbing cache from target Generating report b1dd88cdd8bf09af2539d0b345e647129d8fd55c92b6d824b6ecc53efd531028 navcoin-5.0.1-win.tar.gz ca3032cab6a82629085ce2e04a799be001d384a1fd9b1e7ab6bf132a191a678e navcoin-5.0.1-win32-debug.zip e3d3aa742752ada8b51d8e3c7012c9cc2f0782d567d5fc376d95df65f837a1aa navcoin-5.0.1-win32-setup-unsigned.exe [13:35:27] 4567a0cf593ef67b6633c051eea7700bba4c9fdf1cd1f1f9f72f0cbdde2ccace navcoin-5.0.1-win32.zip 04fb9d832b4bd513df57008513272ac097b5b886c0b07facb795a66868d7975c navcoin-5.0.1-win64-debug.zip 6766f257e886ae1fc92bb2e84cfa483604b0356d74ebed502e5c4c3d7663304a navcoin-5.0.1-win64-setup-unsigned.exe b0e72c4d327aa28cef8b45f77b3591e9fc5e96f22605c551f3c5d3b93e0a0573 navcoin-5.0.1-win64.zip 2193f3eca72624d993b273e6f4044bacfa3575debd5d0032f27074e6541b23c0 [13:35:27] src/navcoin-5.0.1.tar.gz 7fff948a3f4b654f0a9f59e4a62aa37cc164c625680dcaa349ac48e9b0ad067a navcoin-osx-5.0.1-res.yml Done. [13:36:05] @aguycalled [13:36:26] I'm trying osx now [13:36:41] @salmonskinroll could you try to build this branch with gitian? [13:36:47] See if it works for you [13:36:57] Branch is blsct-addict [13:54:29] I see the error on OSX build [13:54:33] src/core/or/scheduler.c:194:5: error: expected expression FALLTHROUGH; ^ ./src/lib/cc/compat_compiler.h:54:21: note: expanded from macro 'FALLTHROUGH' #define FALLTHROUGH __attribute__((fallthrough)) ^ src/core/or/scheduler.c:290:7: error: expected expression FALLTHROUGH; ^ ./src/lib/cc/compat_compiler.h:54:21: note: expanded from macro 'FALLTHROUGH' #define FALLTHROUGH [13:54:34] __attribute__((fallthrough)) ^ 2 errors generated. make[2]: *** [src/core/or/src_core_libtor_app_testing_a-scheduler.o] Error 1 Makefile:11666: recipe for target 'src/core/or/src_core_libtor_app_testing_a-scheduler.o' failed src/core/or/sendme.c:296:5: error: expected expression FALLTHROUGH; ^ ./src/lib/cc/compat_compiler.h:54:21: note: expanded from macro 'FALLTHROUGH' #define FALLTHROUGH __attribute__((fallthrough)) [13:54:34] ^ 1 error generated. Makefile:11708: recipe for target 'src/core/or/src_core_libtor_app_testing_a-sendme.o' failed [13:54:35] I [15:15:48] @aguycalled I fixed the build for osx [15:16:03] Aparently the issue was with -w flag I added to try and get travis build to work [15:16:11] I removed it and gitian build is now working again [15:25:34] thats the same error i see for windows [15:27:31] bd59d446512b76f37670d40e3e2d52f6a574cc23 same gitian commit [16:15:31] OSX is now fixed for me [16:15:36] With the latest commit [16:15:40] On my branch [16:15:45] Can you try it again? [17:00:09] yes and windows too [17:00:26] @mxaddict @0x2830 [17:01:08] It builds all 3 for me now [17:01:13] win, osx, linux [17:01:59] I was getting the failure on OSX, but after I removed the -w flag from depends/hosts/darwin.mk it started working [17:40:37] <0x2830> Ok, I'm merging [17:43:50] I'm doing some debug on the travis build as well, I'll just create another PR if I manage to fix it [18:33:52] > @salmonskinroll could you try to build this branch with gitian? @mxaddict sure [18:34:10] Is it still needed? [18:40:02] i think the gitian builds are fixed now [18:51:38] Nice