[00:48:02] you can tell based on the version @salmonskinroll [00:49:07] Yeah. But I wonder if that would be a good way since they could be the same in the future right? [01:10:14] im not sure if i understand what u mean [01:10:57] it's probably fine for now but you said earlier that the version could be updated in the future correct? would they happen to have the same version at some point in the future? [02:29:27] range consultations will always have certain version bit set [02:59:07] can you list out the version meaning for me please? I have learned that createconsultations "xxx" X X false = 5 createconsultations "xxx" X X true = 7 createconsultationswithanswers = 1 but i've seen a version 3 before and i do not remember how i created it. [07:11:34] 7.4.2 installed from scratch without having to reboot 🙂 [10:09:24] *** Joins: aguycalled_ (~user@unaffiliated/aguycalled) [10:09:24] *** Server sets mode: +cnt [10:10:50] *** Quits: aguycalled (~user@unaffiliated/aguycalled) (*.net *.split) [10:25:09] @salmonskinroll https://github.com/aguycalled/navcoin-core/blob/dao_extension/src/consensus/dao.h#L801 [10:25:36] the different *_VERSION variables indicate which bit needs to be set for each feature [10:26:49] for example, a range consensus parameter version would be BASE_VERSION+ANSWER_IS_A_RANGE_VERSION+CONSENSUS_PARAMETER_VERSION=1+2+8=11 [10:34:44] https://github.com/navcoin/navcoin-core/pull/652 @mxaddict @salmonskinroll @prole [11:15:27] @salmonskinroll can you check and appove this? https://github.com/navcoin/navcoin-core/pull/652 [11:15:33] I think we need this in the next release for sure [15:06:26] yup [15:47:02] @aguycalled you think we need https://github.com/navcoin/navcoin-core/pull/651 for final release? [16:35:58] i noticed that range consultations created from GUI have version number of 3 while ones created with CLI have version number 7. it's probably just different inputs but i can't figure out how to create range consultation in CLI that has version of 3 [16:36:32] Hmmm, can you give exact steps? [16:36:41] For both CLI and GUI [16:36:55] I'll try and replicate, I'm looking at dao branch today too 😄 [16:37:17] BTW, maybe you can take a look at the 651 PR @salmonskinroll [16:37:37] I think we should include that in the next release. [16:37:56] Which I think @prole is going to finalize and CUT in the next few days [16:38:57] nice 🙂 yeah, for GUI i just went to the create consultation tab and then create a consultation where possible answers are numbers. this consultation will have a version of 3. and then i go to the debug window and do createconsultation "my question" 0 10 true to create the same type of consultation, this version will then be 7 [16:39:05] roger that. i'll take a look at it [16:39:30] Ok, I'll see if I can't replicate 🙂 [16:48:48] approved 🙂 [18:36:37] thats wrong, ill fix it. version 7 means more answers are allowed which cant be for range consultations [19:19:54] im curious to know how it can happen. i thought qt is just an extension of navcoind, how can it do something that i can't reproduce in headless mode [20:10:17] the functions are written separately [20:15:26] i see [22:25:06] i think my script for DAO is almost ready. man it's taking me forever [22:25:21] im also close to finish merging the last patches [22:25:24] maybe tomorrow [22:25:32] nice [22:25:43] i'll post it later if you can have a look [22:25:59] it might hurt your eyes since im quite an amateur lol [22:45:08] how to you propose consensus parameter change with multiple answers? [22:45:34] you proposeanswer after the consultation is created [22:45:54] so on creation, you can only suggest one? [22:46:09] yes [22:46:20] ok [22:46:36] QT can suggest multiple though [23:05:33] i didnt implement the rpc cmd [23:05:58] okie dokie [23:27:00] can i have another review here please; https://github.com/navcoin/navcoin-core/pull/653 @mxaddict @salmonskinroll [23:27:12] @prole i think 651 is missing? [23:27:19] it's just for translation but still [23:27:24] okay ill add it [23:27:30] one moment [23:28:38] done [23:28:59] approved [23:29:05] thanks [23:29:11] im cutting the 4.7.2 release now [23:29:14] nice [23:29:25] then we can all do gitian builds off the release tags [23:29:42] and once the hashes are confirmed i will publish it to the website and notify exchanges tomorrow [23:29:52] sounds good [23:29:58] i just notified binance in advance [23:31:33] https://github.com/navcoin/navcoin-core/releases/tag/4.7.2 [23:31:40] is this release title okay? [23:32:27] looks good to me [23:33:43] ive kicked off my gitian build against the 4.7.2 release tag [23:34:04] i guess yours will run automatically against master right alex? [23:34:05] my build node will output the hashes in build.nav.community/binaries [23:34:08] yup [23:34:08] yeah [23:34:10] cool [23:34:17] i'll start mine soon [23:34:19] i need to copy your scripts lol [23:34:25] so i have mine doing it auto [23:34:27] they are on git [23:34:31] nice [23:34:36] https://github.com/navbuilder/autobuilder [23:34:43] ill have a look when i have a spare moment [23:56:14] @aguycalled so the electrum ledger wallet, is the wallet still electrum wallet and therefore the wallet file needs to be backed up? in other words, if i use the same ledger to a new computer and creating a new electrum wallet, will it show the previous coins?