[07:34:27] @aguycalled I completed making stressing node count dynamic and a somewhat usable network topology setting for the script. Please let me know what you think and if you think they are even needed. The script is runnable on my machine. [10:12:22] @prole I'm doing some testing on the GUI PR after I merged latest master [10:12:27] Making sure all is working well [10:12:35] So far it's been smooth sailing. [10:13:34] I'm been able to sync from scratch Bootstrap an older blockchain and reindex was forced (Then wallet synced correctly after reindex) Now I'm testing the verifychain 4 X commands to see if it's all working on my branch [10:14:06] @salmonskinroll maybe you can help me test the GUI pr [10:14:12] In terms of regression testing [10:14:25] I just want to make sure it works well after my merge of latest master. [14:36:50] Definitely. @mxaddict I'll try to spend a couple hours on it today. [14:43:40] I was just able to run the whole gamot of verifychain 4 X commands, from 10 all the way to 1000000 adding a zero each time, then finally I ran verifychain 4 0 for all the blocks [14:43:47] All worked for me. [14:44:09] So seems like it's good. [14:44:36] Let me know your findings @salmonskinroll [14:44:48] @salmonskinrolI meet @salmonskinroll [14:45:09] Someone is trying to impersonate you man 🙂 [14:51:24] 😩 [15:07:49] His name is salmonskinrolI #2195 [15:08:20] Notice the capital I on the end instead of the small l [15:08:30] lol [15:08:49] building your PR now [15:43:15] is the white space below recent transaction intended? [16:24:12] @salmonskinroll that's just the layout, I've not refined that part yet, it's empty space. [16:27:33] gotcha gotcha, syncing testnet at the moment. so far so good [16:28:55] oh and if you have some spare time, can you take a look at PR 641? https://github.com/navcoin/navcoin-core/pull/641 [16:39:33] Yeah, I'll take a look [21:45:28] @salmonskinroll the script looks great ill try running it now [21:45:55] i just made a new version that randomizes the stressing nodes 🙂 im having too much fun with it [21:46:09] next step is to make the script create a random network topology [21:46:22] 👌 [22:12:09] let me know what you think should be improved. i am not sure i will be able to randomly create a topology. if not, i will start moving to implementing DAO stuff [22:14:59] @salmonskinroll I've just finished testing the GUI PR with all the regression testing on linux [22:15:06] Gonna have a shot at it with windows now [22:15:22] Also gonna freshen up the recent transactions list [22:16:38] nice, i sync it up with testnet and tested a couple functions [22:16:49] so far nothing went wrong. [22:17:42] oh actually, first time syncing up with testnet, it got stuck at a block. but after closing and reopening again it synced up normally. [22:18:01] Hmm, that's strange, anything in the log? [22:23:13] nothing strange i can find. forgot to enable debug=1 😔 [22:23:43] i'm getting an error with the script [22:23:50] https://cdn.discordapp.com/attachments/416000318149754881/654795559537737766/unknown.png [22:24:39] and i think the amount of coins sent to the nodes in the initial distribution should be reduced [22:24:42] or calculated [22:25:15] 1610000050=80M which is more than the available amounts, so some nodes might not have coins [22:27:49] roger that, i will reduce it, and since the difficulty is low, having less coins should not matter that much right? [22:27:57] i just uploaded the random stressing node version [22:28:11] ok will try that [22:29:00] i hope the description is clear enough 😛 [22:31:47] is cycles=0 for some reason? [22:31:57] just to save time testing [22:32:13] 👍 [22:34:09] question, right now im connecting nodes by adding node rpc command, but does it matter if it's incoming and outgoing? if so, should i make it mutual? meaning add node 1 to node 2 and node 2 to node 1 [22:34:22] looks like osx's grep does not support -< [22:34:40] oh no, what about -n [22:35:03] but -n would be check if not empty [22:35:10] -n, --line-number Each output line is preceded by its relative line number in the file, starting at line 1. The line number counter is reset for each file processed. This option is ignored if -c, -L, -l, or -q is specified. [22:35:57] might work? i'll update it [22:41:32] looks like its working with -n [22:42:26] nice, but -z is used in many places [22:42:39] did the script work the first time? [22:42:47] wait_until_sync function used -z as well [22:43:51] if it's working, can you tell me what you modified? or just comment it on the gist i guess [22:44:20] substituted grep -z with grep -n [22:44:23] only made two substitutions [22:46:54] right, good to know it's working. will update my stuff [23:04:49] ive merged #641 and am working on the release commit now [23:04:58] how are we all feeling about the current master? [23:05:14] i think current master is ok, what do you think @salmonskinrolI ? [23:05:36] feeling great 😃 , the question would be how we want to handle the cfund function freeze [23:06:06] aw true compeltely forgot about that [23:06:18] haha ah yeah we'll have to undo those changes right [23:06:25] if we're looking to relaunch the cfund [23:06:25] yup [23:06:34] theres a bool if i recall correctly [23:08:04] i was thinking about putting out an RC version first and we all update our testnet nodes and run one last round of testing before pushing it out to the general population & exchanges [23:08:12] just as a sanity check [23:08:15] more than anything [23:08:35] sounds good to me [23:08:47] and if that passes, we consider it production ready [23:08:57] the new salmon script covers better than the testnet i think [23:09:07] but yes, why not [23:09:08] okay [23:09:51] so...a week of testnet and then release? what do you think about the time frame [23:09:53] https://github.com/navcoin/navcoin-core/pull/647 [23:10:19] approved [23:10:23] does that week of testnet mean stressing the testnet again? [23:10:53] IDK we could run the stresser or just make some manual proposals and tests [23:11:43] is it worth running the whole stresser again? [23:12:17] im trying to think what the testnet phase would bring compared to what the script does [23:12:35] the only think i can think of is machines and different OS [23:12:40] only really the fact it runs on different platforms across different geographies [23:13:13] i think we should better run the rc through https://github.com/navcoin/navcoin-core/issues/627 then [23:14:04] sure [23:14:17] agreed [23:14:44] that makes sense, smoke testing the rc works correctly on mainnet [23:15:02] my only thing is that we can't test the cfund on mainnet without risk [23:15:13] which is why i was thinking of running one final testnet round [23:15:29] but if we think running the devnet scripts on the RC is better then lets do that [23:15:35] i think cfund is quite well covered with the scripts [23:15:37] and just test chain sync in mainnet [23:15:39] yeah [23:15:58] my dude @aguycalled you have a twin? how are you discussing here and creating new PRs at the same time [23:16:18] https://tenor.com/view/matrix-gif-5613476 [23:16:26] lol [23:16:27] alex is navcoin [23:16:52] i got a ryzen inside [23:16:56] 24 threads [23:17:18] :p [23:17:34] haha, nice [23:18:07] is pr 642 still needed? isn't it already merged with pr 634 @aguycalled [23:19:21] closed [23:20:32] with the 4.7.2 version commit i might also add some readme documenting the release process? It will be an evolving process and anyone can PR in updates, but i thought perhaps its a good place to capture the recommended process [23:20:59] yup [23:21:09] better document it just in case [23:21:34] cool, im probably going to get some stuff wrong but ill write what i know and we can always ammend it & get feedback [23:21:44] important is to document the database upgrade [23:21:56] (-reindex-chainstate needed in first run) [23:21:56] in the release notes right? [23:22:06] yes, and communications to exchanges and community [23:22:10] cool [23:22:24] oh [23:22:27] the bootstrap node [23:22:30] needs to be updated first [23:22:55] yeah [23:22:57] i think there will be nodes out there that is just not powerful enough to do reindex (owner running out of patience) [23:23:03] https://cdn.discordapp.com/attachments/416000318149754881/654810473606414412/unknown.png [23:23:10] ^ also this (from https://github.com/navcoin/navcoin-core/pull/634) [23:23:16] 👍 [23:24:36] make a big warning reminding people to back up their wallet.dat [23:25:02] in case people got lazy and then delete the whole navcoin4 folder and then come to us [23:25:05] seems like there's already a Release Process document; https://github.com/navcoin/navcoin-core/blob/master/doc/release-process.md [23:25:47] should i modify this one? [23:25:59] yup [23:26:56] cool [23:28:27] are we merging in both 648 and 647 for this version right? [23:28:41] yup [23:28:46] @salmonskinroll can you have a look [23:29:12] already approved 647 and building 648, i know it's just visual but still want to look at it [23:29:12] then we'll consider master in cool down with no more merges [23:29:17] okay [23:29:32] 648 is only for transifex.com to detect the new strings and show them in the website [23:29:41] so translators can translate them [23:30:06] kk [23:30:41] actually, i'll just approve it and build the master [23:32:16] do you wanna hit hte merge button salmon? [23:32:26] you'll be famous on twitter [23:32:29] oh oh, what's going to happen [23:32:32] im scared [23:32:39] you might break everything [23:32:42] (JK) [23:32:44] nice [23:32:47] sure [23:32:49] thx [23:32:54] for 648? [23:32:59] and 647 [23:33:03] you can do them both if you like [23:34:01] in general i usually leave the merging to the author unless its a really simple change just in case they're still working on some fix or feedback even when it has the required approvals [23:34:08] or im sure they're finished [23:34:08] https://cdn.discordapp.com/attachments/416000318149754881/654813263128952832/unknown.png [23:34:14] that button right? [23:34:20] but i thought it might be fun for you to do it [23:34:22] yep! [23:34:28] lol scary [23:35:00] wohoo [23:35:17] 🙌 [23:35:35] nice, thx mate [23:35:51] https://twitter.com/NavCoin/status/1205254906606759938 [23:35:59] haha [23:36:11] making history [23:36:18] nice [23:36:41] oh man, i dont know what went wrong but it looks like you've deleted the whole navcoin repository off github [23:36:54] 😂 [23:36:56] sorry [23:36:58] had to do it [23:37:08] lol [23:37:16] lol man [23:37:26] i would have a heart attack [23:37:31] and die right here [23:40:48] well that should be all the commits [23:41:00] so feel free to start your gitian builds or master builds and being testing [23:41:16] well actually sorry i need to get the new version numbers in there [23:41:17] but that's all really [23:41:36] i should have the PR up in an hour or so [23:41:56] yup, will be doing that, and improving the script as well [23:55:49] great [23:56:01] ill be back once ive done the release candidate PR [23:56:04] signing off for now