[01:48:33] <navcoin-bot> <salmonskinroll> @aguycalled im guessing i need to rebuild to the latest commit for the testing?
[01:48:49] <navcoin-bot> <salmonskinroll> is it ready yet?
[07:34:49] <navcoin-bot> <prole> im rebuilding the latest on 634 now
[07:34:52] <navcoin-bot> <prole> and resuming my code review
[09:54:52] <navcoin-bot> <aguycalled> @salmonskinroll yes i was just merging the last changes in dao_extension branch and realised something was missing. should not affect the tests anyway
[10:47:32] <navcoin-bot> <prole> @aguycalled im nearly done with the second half of my code review
[10:47:49] <navcoin-bot> <aguycalled> great
[10:47:56] <navcoin-bot> <aguycalled> im having a look at the tests failing now
[10:48:17] <navcoin-bot> <prole> one question, all other times GetTransaction has been called in main.cpp we pass in the coinsviewcache as the 2nd to last parameter
[10:48:21] <navcoin-bot> <prole> except here; https://github.com/navcoin/navcoin-core/blob/561339da34c4c981a629f422df943587a6fee375/src/main.cpp#L2265
[10:48:26] <navcoin-bot> <prole> we pass in the inputs
[10:48:32] <navcoin-bot> <prole> is this correct? or should this be updated also?
[10:49:03] <navcoin-bot> <prole> ah derp
[10:49:04] <navcoin-bot> <prole> sorry
[10:49:10] <navcoin-bot> <aguycalled> its just the variable has a different name maybe
[10:49:11] <navcoin-bot> <prole> inputs is an instance of coinsviewcache
[10:49:14] <navcoin-bot> <prole> yeah
[10:49:22] <navcoin-bot> <aguycalled> not a global var
[10:49:23] <navcoin-bot> <prole> never mind
[10:50:04] <navcoin-bot> <prole> feels like the hard part of the review for me was yesterday where i was intensely reading all the logic changes in the cfund code to make sense of them
[10:50:17] <navcoin-bot> <prole> and now today its mostly looking at where you've implemented those new functions
[10:50:39] <navcoin-bot> <prole> all making sense so far
[10:52:16] <navcoin-bot> <aguycalled> cool
[11:01:17] <navcoin-bot> <prole> okay, ive submitted another review with a couple of questions but should be easy to answer
[11:01:48] <navcoin-bot> <prole> i have reviewed everything except the changes to main.cpp and my brain is too tired to do that tonight, its 11pm
[11:02:18] <navcoin-bot> <prole> i want to spend some time to look at the diff with some context so i can read and properly understand the changes
[11:02:32] <navcoin-bot> <prole> but i dont think i have the brain power left in me today
[11:02:50] <navcoin-bot> <prole> we need another person to approve this anyways, so one more day isn't going to break us i don't think
[11:08:28] <navcoin-bot> <aguycalled> @salmonskinrolI im reverting that patch, the purpose was to improve performance but the tests are non deterministic failing with it so i will just revert it. i think its better we focus on stability now and have a look at performance later
[11:08:41] <navcoin-bot> <aguycalled> yes i think salmon will approve when he feels confortable with the tests hes running
[11:11:10] <navcoin-bot> <aguycalled> this should bring back the tests you commented @prole
[15:16:31] <navcoin-bot> <salmonskinroll> tests are passing still. i will build to the latest commit after this round passes and then start another around. if that round passes without problems i will approve the PR. should be before end of today
[21:13:57] <navcoin-bot> <prole> nice
[21:14:04] <navcoin-bot> <prole> i will also finish my final code review today
[21:14:19] <navcoin-bot> <prole> so hopefully later today we can merge and start to prepare the release tag
[21:14:25] <navcoin-bot> <prole> and start gitian building etc
[21:26:53] <navcoin-bot> <salmonskinroll> nice, @aguycalled should we cancel 642 since it's incorporated in 634? oh and im seeing two aguycalled again.