[00:31:54] @prole verifychain pr tests passes now [10:24:14] also confirmed it fully syncs mainnet [10:24:47] running a few more tests before labelling again as ready for review [20:21:17] https://github.com/navcoin/navcoin-core/pull/634 this is ready for review [20:21:19] passed all my tests [20:21:39] @mxaddict @prole @salmonskinroll [20:23:59] Ack [20:27:42] p.s. completely removing the project, cloning again from git, building depends and then making with the depends directory (and --disable-hardening --enable-debug) worked [20:27:51] so not sure what was wrong [20:27:55] but i turned it off and on again [20:29:25] I'm probably not going to have much of a chance to review the verifychain PR until after my contract work is done for the week. But i am really keen to give it a thorough code review before its merged [20:29:43] if we can hold off until my thursday to merge [20:31:14] if its more important for mxaddict & salmon to review then merge so we can get it on the testnet nodes, then that's okay too. i can do a post-review [20:31:22] either way, im going to have a look at this later in the week [20:31:43] cool, i am going to upgrade my testnet nodes to this pr now anyway [20:31:48] okay [20:34:25] and some of my mainnet nodes too [20:34:59] i'll do full syncs and test verifychain succeeds [20:50:54] 👍 [20:51:27] im doing a full sync on that tokyo node, see what happens