[01:23:57] <navcoin-bot> <prole> PR #629 Seed nodes has been merged
[05:49:26] <navcoin-bot> <mxaddict> @sakdeniz looks good
[10:12:23] <navcoin-bot> <sakdeniz> https://cdn.discordapp.com/attachments/416000318149754881/647363741482090496/Screenshot_from_2019-11-22_12-11-52.png
[10:12:54] <navcoin-bot> <sakdeniz> built @mxaddict gui update, looks nice
[10:41:39] <navcoin-bot> <mxaddict> @sakdeniz can you do some testing on that branch with testnet? 🙂
[10:42:06] <navcoin-bot> <mxaddict> And post any issues with it on the PR? ❤️
[10:42:24] <navcoin-bot> <mxaddict> I've updated that branch based on master as well, so it should work with the new testnet
[11:19:34] <navcoin-bot> <aguycalled> is it ready for review? @mxaddict
[11:20:47] <navcoin-bot> <mxaddict> No, but I wanna test all the major functionality on the send/receive views
[11:21:06] <navcoin-bot> <mxaddict> There were lots of code changes to code related to them
[11:21:44] <navcoin-bot> <mxaddict> I'll be pushing final changes for this PR tomorrow.
[11:22:02] <navcoin-bot> <mxaddict> I've been testing it on windows as well, and seems to be working well.
[12:00:44] <navcoin-bot> <sakdeniz> https://cdn.discordapp.com/attachments/416000318149754881/647391005347414041/Screenshot_from_2019-11-22_14-00-28.png
[12:01:12] <navcoin-bot> <sakdeniz> @mxaddict it works on testnet
[12:19:50] <navcoin-bot> <mxaddict> @aguycalled did you see my comment on https://github.com/navcoin/navcoin-core/pull/632
[12:20:10] <navcoin-bot> <mxaddict> Is it normal for the node to proceed after re-index like it's syncing from genesis block?
[12:20:42] <navcoin-bot> <aguycalled> yes its normal, its not really syncing but re-reading the blocks to rebuild the chainstate
[12:20:49] <navcoin-bot> <aguycalled> if you turn off internet it keeps going
[12:33:58] <navcoin-bot> <sakdeniz> https://cdn.discordapp.com/attachments/416000318149754881/647399369267478539/Dao_decentralized_autonomous_organization_crypto-512.png
[12:34:13] <navcoin-bot> <aguycalled> i like that icon
[12:34:24] <navcoin-bot> <aguycalled> maybe a bit more square-shaped?
[12:34:36] <navcoin-bot> <sakdeniz> https://www.iconfinder.com/icons/5373019/autonomous_crypto_dao_decentralized_organization_icon
[12:37:08] <navcoin-bot> <mxaddict> Wow, that's a nice icon
[12:37:47] <navcoin-bot> <mxaddict> @aguycalIed ok, yeah, I noticed it was not using bandwidth
[12:38:02] <navcoin-bot> <sakdeniz> better than pig 🙂
[12:38:54] <navcoin-bot> <mxaddict> @aguycalIed  you weren't joking about the tests for reindex taking a while 🙂
[12:39:14] <navcoin-bot> <mxaddict> I kinda wish I was runnning this on my home PC, laptop is taking ages 😄
[12:39:54] <navcoin-bot> <mxaddict> BTW, I got upgraded to ryzen now too, I finnaly found a 3900X in stock, but sadly they only had 2x16GB 3600 C17 RAM
[12:40:01] <navcoin-bot> <mxaddict> But I'll take what I can get ❤️
[12:40:30] <navcoin-bot> <aguycalled> yeah
[12:40:39] <navcoin-bot> <aguycalled> even on the ryzen a full verifychain was taking 30min
[12:47:00] <navcoin-bot> <sakdeniz> is this branch https://github.com/aguycalled/navcoin-core/tree/dao_extension correct for dao? @aguycalled
[12:47:07] <navcoin-bot> <aguycalled> yes
[17:27:00] <navcoin-bot> <mxaddict> @aguycalIed the reindex on my laptop passed
[17:27:08] <navcoin-bot> <mxaddict> I've approved and merged the PR
[17:39:45] <navcoin-bot> <aguycalled> cool im with the verifychain pr
[17:39:59] <navcoin-bot> <aguycalled> cf supply is off at one block in that branch trying to find whats the cause
[17:41:00] <navcoin-bot> <mxaddict> Is that why the one of the cfunddb tests is failing?
[17:41:26] <navcoin-bot> <mxaddict> I'm working on the FINAL FORM for the GUI branch 😄
[17:42:55] <navcoin-bot> <mxaddict> https://tenor.com/view/isnt-even-my-final-form-gif-11810117
[17:43:23] <navcoin-bot> <salmonskinroll> nice, ready to start testing the GUI
[17:46:27] <navcoin-bot> <mxaddict> @salmon3s I know you'll find some bugs, I made a lot of changes and sometimes when you are on the inside, you can't see the bugs yourself.
[17:46:48] <navcoin-bot> <salmonskinroll> i'll try my best 🙂
[17:52:00] <navcoin-bot> <mxaddict> @aguycalIed make -j24 is amazing on this Ryzen, worth every penny ❤️
[17:52:22] <navcoin-bot> <aguycalled> yes:)
[17:52:35] <navcoin-bot> <aguycalled> syncing is not as fast as i one would expect tho, dont know why
[17:53:03] <navcoin-bot> <aguycalled> did you install osx?
[17:57:06] <navcoin-bot> <mxaddict> I'm running windows right now, I need to get a new SSD before I can install OSX
[17:57:43] <navcoin-bot> <mxaddict> I'm running linux on a 120GB SSD, Windows on 120GB SSD, and 1TB HDD for general storage, all SATA drives
[17:58:16] <navcoin-bot> <mxaddict> I'm looking to get a 2x512GB NVMe or 2x1TB NVMe depending on available stock here
[18:00:50] <navcoin-bot> <mxaddict> @aguycalIed when running reindex on a GUI node, the wallet looks frozen even though it's not
[18:01:07] <navcoin-bot> <mxaddict> I'm looking to fix this so it does not freeze, any idea where to start looking?
[18:01:29] <navcoin-bot> <aguycalled> i guess its because the reindex function holds a lock
[18:01:39] <navcoin-bot> <aguycalled> but let me see
[18:01:40] <navcoin-bot> <salmonskinroll> saw that as well when i did it
[18:06:56] <navcoin-bot> <aguycalled> i dont see a lock, the functions is ThreadImport() in init.cpp @mxaddict
[18:07:07] <navcoin-bot> <aguycalled> but theres a while true
[18:07:08] <navcoin-bot> <mxaddict> Thanks, I'll poke around in that function
[18:07:28] <navcoin-bot> <aguycalled> but its supposed to be launched in a different thread
[18:08:15] <navcoin-bot> <mxaddict> I see that the wallet is using very little CPU while this is running
[18:08:15] <navcoin-bot> <mxaddict> https://cdn.discordapp.com/attachments/416000318149754881/647483494901219338/Capture.PNG
[18:08:38] <navcoin-bot> <mxaddict> Looks like 1 thread is at 100% CPU and 3 more that are like 20-40%
[18:08:49] <navcoin-bot> <aguycalled> yeah mmm
[18:08:56] <navcoin-bot> <aguycalled> blocks need to be validated sequentially
[18:09:25] <navcoin-bot> <aguycalled> so theres not much to parallelise besides signature verification, but our blocks use to be empty so not many tx to verify per block
[18:12:08] <navcoin-bot> <mxaddict> I'll poke around the code, I think that while(true) smells fishy
[18:12:20] <navcoin-bot> <mxaddict> I wonder if that is the reason for the GUI to freeze
[18:12:44] <navcoin-bot> <mxaddict> I'll test moving the code in the while(true) loop into a new thread and see if that helps
[18:14:05] <navcoin-bot> <aguycalled> mmm
[19:06:59] <navcoin-bot> <aguycalled> if my verifychain pr ends up being accepted as a fix, it'll require every wallet to reindex
[19:07:16] <navcoin-bot> <aguycalled> so if we can improve the ux of that part itll be great
[19:13:17] <navcoin-bot> <salmonskinroll> is there a way to trigger reindex if older version detected?
[19:13:33] <navcoin-bot> <aguycalled> itll get triggered automatically when trying to read the old db
[20:12:37] <navcoin-bot> <mxaddict> @aguycalIed I've been running reindex in the testnet node that I have
[20:12:59] <navcoin-bot> <mxaddict> And seems the GUI of the wallet hangs only while the headers are loading
[20:13:22] <navcoin-bot> <aguycalled> the its loadblockindexguts
[20:13:23] <navcoin-bot> <mxaddict> Once all the headers are done loading the wallet becomes responsive again
[20:13:39] <navcoin-bot> <mxaddict> Alright, I'll check it out.
[20:14:01] <navcoin-bot> <mxaddict> That runs concurrent to the blocks right?
[20:14:20] <navcoin-bot> <mxaddict> Block headers finish first as they are easier to verify
[20:14:29] <navcoin-bot> <aguycalled> i would say no, if by concurrent you mean in parallel
[20:14:42] <navcoin-bot> <mxaddict> Hmmm, they don't?
[20:14:52] <navcoin-bot> <mxaddict> I mean they are not run in parallel?
[20:15:19] <navcoin-bot> <aguycalled> i dont think so, id say they depend of the first being completely finished but im not completely sure
[20:20:02] <navcoin-bot> <prole> I know #632 has already been merged, but I can confirm my node successfully reindexed overnight.
[21:12:23] <navcoin-bot> <mxaddict> @aguycalIed what is the naming convention for bool variables?
[21:12:46] <navcoin-bot> <mxaddict> I notice that alot of bool vars are named with an f in front, I'm not sure why that is.
[21:55:18] <navcoin-bot> <mxaddict> @aguycalIed  @salmonskinroll
[21:55:31] <navcoin-bot> <mxaddict> Looks like I found the cause of the freezing GUI
[21:55:53] <navcoin-bot> <mxaddict> It seems it was caused by a change to the code I pulled from upstream BTC repo
[21:56:11] <navcoin-bot> <mxaddict> When I ported the sync modal (The progress UI)
[21:56:20] <navcoin-bot> <mxaddict> I'm making the PR now
[22:10:54] <navcoin-bot> <salmonskinroll> roger that, will do a reindex again with your PR
[22:24:02] <navcoin-bot> <aguycalled> yes normally i start then with f from flag
[22:29:57] <navcoin-bot> <mxaddict> https://github.com/navcoin/navcoin-core/pull/638
[22:31:55] <navcoin-bot> <mxaddict> I created a PR for bitcoin wallet as well 🙂
[22:31:56] <navcoin-bot> <mxaddict> https://github.com/bitcoin/bitcoin/pull/17565
[22:32:10] <navcoin-bot> <mxaddict> Hoping to get my first contribution upstream ❤️
[22:34:56] <navcoin-bot> <mxaddict> @aguycalIed now that you mentioned it, f=flag does make sense 🤣