[00:02:09] <navcoin-bot> <mxaddict> Gotcha, then I think it's worth it to create the test
[00:02:50] <navcoin-bot> <prole> okay, let me see if i can whip it together
[00:03:02] <navcoin-bot> <prole> then i will commit it and approve the pr
[00:03:09] <navcoin-bot> <prole> (if the tests pass)
[00:03:19] <navcoin-bot> <mxaddict> Ack
[00:04:00] <navcoin-bot> <prole> how are you going with the UI ?
[00:04:46] <navcoin-bot> <prole> wanna try get these 3 PRs cleared ASAP and 4.7.1 pushed out so i can get started on the DAO and whatever else
[00:06:45] <navcoin-bot> <mxaddict> It's 06:05 here now, I'm about to head to bed, but the UI PR is top of my list when I get up (Hopefully 8-10 hours from now)
[00:06:52] <navcoin-bot> <prole> okay sweet
[00:07:02] <navcoin-bot> <prole> im working on core today, but ill focus on the other 2
[00:07:10] <navcoin-bot> <mxaddict> I've finished the changes on the home/overview page for scaling issue (Windows 10)
[00:07:12] <navcoin-bot> <prole> and then again on my saturday or sunday
[00:07:21] <navcoin-bot> <mxaddict> And need to finish the notification section (Bottom of the wallet)
[00:07:38] <navcoin-bot> <mxaddict> And I think that is the last part, then PR should be "ready for review"
[00:07:42] <navcoin-bot> <prole> if you can give it a good nudge and get it ready for review in a couple days time that would mean we can get it all squared away this weekend.
[00:08:03] <navcoin-bot> <mxaddict> Nice
[00:08:28] <navcoin-bot> <mxaddict> If you can get to them, there are some other PRs with minimal review required, like the for loop changes
[00:08:49] <navcoin-bot> <mxaddict> I mean after the more important changes though.
[00:08:51] <navcoin-bot> <prole> okay, if i run out of stuff ill look at them perhaps just list the PR # here
[00:09:38] <navcoin-bot> <prole> im currently looking at the [needed for final release] ones
[00:09:45] <navcoin-bot> <mxaddict> https://github.com/navcoin/navcoin-core/pull/525 https://github.com/navcoin/navcoin-core/pull/509 https://github.com/navcoin/navcoin-core/pull/554 https://github.com/navcoin/navcoin-core/pull/560 https://github.com/navcoin/navcoin-core/pull/561
[00:09:51] <navcoin-bot> <prole> sweet
[00:10:12] <navcoin-bot> <mxaddict> These aren't needed
[00:10:15] <navcoin-bot> <prole> ill look at this if i finish the other 2 needed for final release ones and you havent got the UI ready yet
[00:10:32] <navcoin-bot> <mxaddict> But they would clean up some of our codebase and make it more inline with changes from upstream.
[00:11:00] <navcoin-bot> <mxaddict> More of like "creature confort" changes 😄
[00:11:40] <navcoin-bot> <prole> sure
[00:11:52] <navcoin-bot> <mxaddict> For the curl/ssl PR (https://github.com/navcoin/navcoin-core/pull/603) you will need to test with a fresh osx and windows install
[00:12:08] <navcoin-bot> <mxaddict> As if you have openssl or other libs that provide cacert.pem files somewhere on the system
[00:12:13] <navcoin-bot> <mxaddict> The old code would work
[00:12:59] <navcoin-bot> <mxaddict> But the new PR fixes that dependency by using schannel on windows and secure-transport on osx (Old builds were using openssl for Linux, Mac and Win)
[00:13:40] <navcoin-bot> <prole> okay shiet
[00:13:44] <navcoin-bot> <prole> bit of a process
[00:13:51] <navcoin-bot> <prole> ill fire up the mac mini
[00:13:55] <navcoin-bot> <prole> and see what the deal is
[00:13:56] <navcoin-bot> <mxaddict> I guess VMs would do?
[00:14:12] <navcoin-bot> <prole> can you VM OSX?
[00:14:22] <navcoin-bot> <prole> i dont know if there are virtual box images for it is there?
[00:14:34] <navcoin-bot> <mxaddict> Yes, on and OSX machine I believe it's possible
[00:14:45] <navcoin-bot> <prole> okay i can look into that
[00:14:48] <navcoin-bot> <mxaddict> Basically OSX in parallels
[00:15:10] <navcoin-bot> <mxaddict> I guess you could use parallels for both OSX vm and Windows VM
[00:15:21] <navcoin-bot> <mxaddict> Since you are testing on a mac
[00:15:37] <navcoin-bot> <mxaddict> Goodluck 👌
[00:16:57] <navcoin-bot> <mxaddict> @aguycalled should we make this PR needed for final release? https://github.com/navcoin/navcoin-core/pull/520
[00:17:14] <navcoin-bot> <mxaddict> I don't think I've fully reviewed this one.
[00:20:47] <navcoin-bot> <aguycalled> needs the functional tests iirc
[00:48:39] <navcoin-bot> <aguycalled> for the max reorg pr, yes a test wont hurt. but in this case we are mostly interested to check that it fixes the art-of-bug disclosure. this should be checked at least manually
[00:50:26] <navcoin-bot> <prole> my rpc test seems to pass but then hit various stderr after causing the tests to report as failed
[00:50:32] <navcoin-bot> <prole> https://cdn.discordapp.com/attachments/416000318149754881/629087853296615426/Screen_Shot_2019-10-03_at_11.47.01_AM.png
[00:50:37] <navcoin-bot> <prole> for example
[00:51:16] <navcoin-bot> <aguycalled> no clue about that one right now
[00:51:27] <navcoin-bot> <prole> okay, probably some problem with my setup
[00:51:31] <navcoin-bot> <prole> ill see if i can figure it out
[00:51:59] <navcoin-bot> <prole> i build the depends successfully and built using it and the program compiles and runs
[00:52:00] <navcoin-bot> <prole> so IDK
[00:52:12] <navcoin-bot> <aguycalled> try running the test directly
[00:52:19] <navcoin-bot> <aguycalled> python3 ../rpc-tests/whatever.py
[00:52:28] <navcoin-bot> <aguycalled> and also checking the logs at the data folder it says at the beginning
[00:52:36] <navcoin-bot> <aguycalled> /var/folders/...
[00:52:39] <navcoin-bot> <prole> okay good idea
[00:52:44] <navcoin-bot> <prole> might give some clue
[00:53:20] <navcoin-bot> <prole> ill check back in later on, must be late for you! get off the internet and get some sleep!
[00:53:21] <navcoin-bot> <prole> 😛
[08:44:06] <navcoin-bot> <prole> I've written a test here which i think should pass, but it fails. The two nodes reorg back to the same chain after being diverging for 501 blocks.
[08:44:08] <navcoin-bot> <prole> https://github.com/navcoin/navcoin-core/pull/604/files
[08:45:12] <navcoin-bot> <prole> i have to wrap up for the day, but if either of you can run and double check my test that would be great
[08:45:50] <navcoin-bot> <prole> maybe im doing something wrong in the test
[08:47:18] <navcoin-bot> <prole> @aguycalled @mxaddict
[08:47:22] <navcoin-bot> <prole> ❤
[08:47:53] <navcoin-bot> <prole> im taking tomorrow off (its my partners birthday) but ill be back online and working on this my Saturday & Sunday
[12:03:41] <navcoin-bot> <mxaddict> I'll see if I can replicate the issue that you're getting on the test
[14:33:57] <navcoin-bot> <salmonskinroll> does the test create two nodes locally?
[21:03:47] <navcoin-bot> <prole> Yep
[22:37:51] <navcoin-bot> <prole> creates two nodes, connects them together, mines 1000 blocks, checks they are both at the same block hash & height, disconnects them, individually mines 501 blocks on each, an extra one on the 2nd node so there is a clear longest chain, then reconnects them.
[22:38:23] <navcoin-bot> <prole> the assumption is that if 500 deep re-orgs were not allowed the two nodes should remain on their seperate chains after attempting to reconnect
[22:38:54] <navcoin-bot> <prole> but they both end up on the same longest chain, (the one that mined the extra block)
[23:07:55] <navcoin-bot> <salmonskinroll> Excuse me ignorance. How does it create two nodes locally? Usually it only allows one NAVCoin daemon right? And can I create two nodes locally manually?