[05:11:07] @aguycalled I think I've managed to get curl to build with secure-transport [05:11:13] I'm doing a gitian build now [05:11:26] Will post windows and osx binaries for testing when done [05:11:36] @salmonskinroll do you have OSX you can test with? [05:18:39] @aguycalled hopefully if this works, then no need to do the embeded cacert 😄 [05:53:43] unfortunately no, 😛 i sold my macbook a while ago [11:43:35] I've got osx [11:43:42] And I think Alex also [11:43:48] yes im on osx [11:44:16] Yeah, but you both also had openssl installed on the system [11:44:34] And old version worked fine :D [11:44:36] Ah [11:44:53] i have other mac at home which i could use to test. i dont think that one has openssl [11:45:12] Ah yeah I also have a Mac mini lying around somewhere if we need it [11:45:12] Alright [11:45:33] I don't remember who, but someone here had a mac that would fail to get price data [11:45:57] Not sure [11:46:02] @here? [11:46:35] Cause if your mac has openssl installed, the openssl implementation of curl would find the certificate bundle and use it. [11:46:37] :raisedeyebrow: [11:47:17] Looking for someone with OSX to test something [11:47:28] I've got os x [11:47:48] 10.14.6 [11:48:00] But do you have openssl or or ca-cert-bundle NOT installed? [11:48:13] We need a non dev mac basically [11:48:37] Well, non tried to compile NavCoin probably [11:49:33] I'll try and back read to find who helped me test last time. [11:50:01] How do you test for openssl? openssl -v [11:50:05] In terminal? [11:50:11] I'm not at my laptop [11:50:51] IDK, I think there are multiple ways to test it [11:51:15] But the curl code checks for a certificate authority bundle [11:51:40] Usually located here: /etc/ssl/certs [11:51:51] There are some other locations it checks. [11:52:20] Openssl is installed by default I believe [11:52:36] It is situated in /use/bin/openssl [11:52:50] I don't think so, which is why some mac users were failing to get price data [11:52:53] I only install the /usr/local/bin so... [11:53:04] I found it [11:53:21] @magpie17 you around? 🙂 [11:53:28] We need to test that price fetch issue [11:53:44] From what I can remember you had a mac that could replicate the issue 😄 [11:55:21] Ohh, anyone here have windows? 🙂 [11:55:26] We need to test the windows build as well [11:57:14] Binaries: http://static.codedmaster.com/nstake/navcoin-4.7.0-win32-setup-unsigned.exe http://static.codedmaster.com/nstake/navcoin-4.7.0-win64-setup-unsigned.exe http://static.codedmaster.com/nstake/navcoin-4.7.0-osx-unsigned.dmg [11:57:46] Windows version uses schannel and osx version uses secure-transport [12:47:14] @mxaddict yep that was me, running a mac mini with 10.13.6 and I'm still only getting the first 6 or so prices to load. What do you need me to check? [12:47:43] Can you test out this build: http://static.codedmaster.com/nstake/navcoin-4.7.0-osx-unsigned.dmg [12:47:53] To see if it's loading price data [12:49:24] ok no problem [12:58:55] @mxaddict Success! I can see amounts populated in all the currencies I chose. And here's a pic of my last 3 (orphan) txns [12:58:56] https://cdn.discordapp.com/attachments/416000318149754881/626372053267775498/unknown.png [12:59:57] prior to this build, txns shown in other currencies would always show up as zero amount values [13:01:24] Nice [13:01:43] Can you comment your findings on the PR here: https://github.com/navcoin/navcoin-core/pull/603 [13:01:47] Thanks [13:02:23] sure no problem [13:15:04] @mxaddict Done! [13:50:32] @magpie17 thanks [15:18:49] @mxaddict testing it on windows 7 [15:31:21] what needs to be tested? all currencies are displaying numbers [15:42:27] that means the patch works [16:21:30] how do you gitian build a PR? [16:21:53] -commit=branch [16:27:19] but how to point a branch to a PR? [16:28:05] for example https://github.com/navcoin/navcoin-core/pull/605 refers to split-staking-rewards in aguycalled repo [16:28:24] ah, okay [16:28:35] USE_DOCKER=1 ./bin/gbuild -j8 --commit navcoin-core=split-staking-rewards --url navcoin-core=http://github.com/aguycalled/navcoin-core ../navcoin-core/contrib/gitian-descriptors/gitian-osx.yml [16:31:25] what other PR needs testing? aside from DAO i guess. [16:31:40] everything with the ready for review tag [16:32:12] right, most of them i don't know what to test. so just build and run i guess? [16:37:57] there's already an automated system which checks building works for every os. so building just to check that it builds is not necessary [16:39:38] some of them simply need a code review like https://github.com/navcoin/navcoin-core/pull/509. for others is just checking that the new functionality works like https://github.com/navcoin/navcoin-core/pull/527 [16:41:01] cool, i saw that one as well. will test it later [16:48:33] @aguycalled @prole [16:48:39] We might have a new dev [16:48:49] I'm setting up a meeting with him tomorrow [16:48:56] To talk about working on core [16:49:18] I'll see if I can talk him into it 👌 [16:49:26] that's great news [16:49:42] good luck for the meeting [16:49:45] He's already familiar with crypto as he's also a crypto fanboi. [16:49:49] So we'll see [19:12:49] That would be great