[04:10:20] @prodpeak [04:10:26] Can you make a PR [04:10:52] For that change you made on pool node that prioritize lower balance inputs when checking for stakes? [04:11:09] I think it's a usefull change for the main core wallet as well [09:23:22] Sure. I didn't put it behind a feature flag nor have I written tests 🤫 [10:23:36] Hmmmm, I think it might not need a feature flag, should be just on by default [10:23:49] Cause if it's just a standalone node, does not really matter [10:23:59] But it is useful if you pool coins [10:24:28] Not sure how a functional test would work with that either, cause it's still kinda random [10:25:04] Like if the staking low coin input does not stake, it will check the higher balance input next and would stake that [10:25:11] So hard to write a testcase for it. [10:25:33] @aguycalled @prole what do you think? [10:57:30] I'll build the PR and on review let me know if anything additional is required [11:01:06] Alright [12:59:04] sounds good [13:01:06] i got my other nodes setup today [13:02:49] so i have a gitian builder, test environment, bootstrap server and 2 navpay isntances running now [13:02:59] gonna use the bootstrap server as also a network monitor [13:03:34] to try and keep an eye out for network anomolies and ping me on telegram if it gets stuck or sees the block explorers out of sync [13:04:15] then ill get to using the test environment + my local dev environment to try and see what i can dig up about these invalid block rejections. [13:04:55] also done some more work on navpay kauri which is nearly ready to start actually building functionality [13:05:02] just 1 more framework thing to sort out i thihnk [13:05:57] https://cdn.discordapp.com/attachments/416000318149754881/606080101909528577/Screen_Shot_2019-07-31_at_11.05.47_PM.png [13:06:02] look at that code coverage report [13:06:05] its a beautiful thing [13:07:17] im off to bed, peace out homies [13:16:05] https://github.com/navcoin/navcoin-core/pull/578 [13:16:59] @prole I'm ready to start contributing to Kauri! [13:32:12] Do you have a set of UX wireframes? [20:57:07] i noticed that we have quite a few PRs ready for review. Are you saving those for the DAO release @prole ? [21:44:33] @salmonskinroll its more that we're concentrating on fixing some bugs to get 4.7.0 released than reviewing new PRs. Feature cut off for 4.7.0 has already been. [21:46:00] @prodpeak Carter put some work into the UX for kauri, the demo's can be viewed here: https://github.com/Encrypt-S/kauri-wallet-demo [21:46:32] I have all the design files for it, but i dont know if its quite right. im going to have a good go at it once i have all the pieces in place [21:46:59] still probably a couple of weeks away from building features or collaborating [21:48:47] Will do [21:48:59] Wak through videos look great