[04:33:51] @aguycalled @prole [04:34:05] https://github.com/navcoin/navcoin-core/pull/558 [04:34:19] Fixes that missing lock that I experinced on the RC build I was testing [08:12:56] *** Joins: aguycalled (~user@unaffiliated/aguycalled) [08:13:00] *** Server sets mode: +cnt [13:05:24] @Goku https://github.com/navcoin/navcoin-core/pull/557#issuecomment-508990241 [14:03:21] @mxaddict Looks good mate. You should modify the padding of the ‘body’ part to be equal relative to the top and the left or alternatively have it in the middle. [14:08:04] @navatw yeah, I'm still making other changes to the branch, just wanted to show the menu [14:09:03] Ok, cool. Just wanted to mention it in case it was final. [17:37:05] @prole @aguycalled I've created another PR adding a LOCK(cs_main) [17:37:28] I've added neede for final release on those two PRs as I think they are good to include for stability of the wallet [18:28:00] @Goku [18:28:00] https://cdn.discordapp.com/attachments/416000318149754881/597463838539120650/SPOILER_out.mp4 [18:29:33] amazing @mxaddict [18:29:48] im not sure about the colors for the selected menu option [18:37:16] Yeah, I was trying to make the colors look better, but I had a bit of trouble with the button style sheet 😄 [18:37:25] So I left it as gray for now [18:37:48] Issue was with the text color would change, but QPushButton QIcon would stay Gray for some reason [18:38:54] This PR also contains changes for the UI scaling of the Splash Screen (Will now scale in HDPI/Retina screens) [18:39:59] Sidebar also scales properly on HDPI/Retina (Old top menu stayed small before) [18:42:18] Also, I've added SVG to the QT depends [18:42:27] But seems it won't compile on OSX [18:42:35] I'm still figuring that out 😢 [18:43:50] @aguycalled Do you think we really need the warning about votes? [18:44:01] The bubble seems like an elegant solution [18:44:11] In my PR i've removed the pop up already [18:44:54] So last change for this PR is the fix for OSX build (Travis-CI and Gitian fail to compile with the svg support) [19:01:53] @prole if you have a few minutes [19:01:55] Can you check https://github.com/navcoin/navcoin-core/pull/558 [19:24:07] the question is if the bubble is enough [19:24:39] one idea could be to extend the top bar with the nav logo and use the empty space where the buttons were before to show warnings ? [19:24:41] Hmmm, yeah, I see some people just ignoring it [19:25:40] Actually, I was thinking that the warnings can be more of a floating QLabel (Attached the parent frame) [19:25:48] i did not like dao icon in core wallet [19:25:49] That has a (X) on the right side to dismiss [19:26:18] And the warning can show up again in X number of seconds/minutes to annoy the user [19:26:25] What do you think @aguycalled ? [19:26:38] @sakdeniz we have an issue to create consistent/better icons on core [19:26:57] Maybe you can comment and make some suggestions here: https://github.com/navcoin/navcoin-core/issues/552 [19:27:01] yes i like that idea [19:27:58] Ok, I'll implement it like that then, also, I will change the NTP warning to match as well just to make the wallet look more professional. [19:28:20] @aguycalled so 10 minute interval for the warnings? [19:28:37] Basically if dismissed, show it again after 10 minutes? [19:31:48] can you add some bool to verify hex is valid while submitting community fund proposal hex with sendrawtransaction [19:31:50] yes [19:32:03] ill do it as annoying as possible [19:32:26] Ok, 5 minutes then 😄 [19:32:34] if something is wrong while submitting proposal to network, it just returns "bad cfund proposal" [19:32:43] so we don't know whats wrong [19:33:12] @sakdeniz new RPC command to validate cfund raw tc? [19:33:13] need some details about error [19:33:29] yes [19:33:34] also need more details about error [19:33:35] Well, we could just add better RPC errors on sendrawtx [19:34:01] not enough funds, no deathline specified, no subject specified etc. [19:37:58] can somebody create a tutorial for build core on windows 10 [19:38:43] i can help you about ui [19:40:02] @sakdeniz I've never tried building on windows [19:40:20] AFAIK I think it's possible, just not documented. [19:40:33] Might be easier for you to run a VM, and build via the VM [19:40:45] You can build windows binaries via an ubuntu vm [19:40:53] Or maybe try the ubuntu bash on windows 10 [19:40:59] i don't want to use it on vm [19:41:34] What about the ubuntu bash on windows 10? I think you can now install it via windows store [19:42:01] but its just include console right? [19:42:06] not gui? [19:42:17] It's just a CLI [19:42:30] but once you build on cli, you can run the binaries on windows to test [19:43:35] IIRC you can use the ubuntu bash terminal to change working DIR to a windows path Then from there, you can clone the code, install dependcies, compile Then in windows explorer, go to the build dir and run the compiled app [19:43:46] It's bulky though [19:44:06] VS Studio would be best if compiling/coding on windows, but I've not tried it yet. [19:45:31] is compile build for all os? [19:45:56] If you compile with make via linux, you can build for linux, windows or osx [19:46:30] is 18.04 ok? [19:47:18] You just have to select the correct target when running the ./configure -prefix=\pwd`depends/$platformandcd depends && make HOST=$platform` [19:47:47] Yes, 18.04 is the current recommended to use for core [19:48:00] installing [19:48:14] Ack, in a VM? or on a different PC? 😄 [19:48:32] nope ubuntu bash 18.04 [19:48:36] I see [19:49:02] i don't want to switch windows between on vm and windows [19:49:18] Yeah, gets anoying fast 🤣 [19:49:55] ^ these two commands is for install dependencies right? [19:51:30] Steps to build windows binaries: git clone cd navcoin-core cd depends make -j HOST="x86_64-w64-mingw32" cd .. ./autogen.sh ./configure --prefix=`pwd`/depends/x86_64-w64-mingw32 make -j [19:51:40] Those should be the steps [19:51:44] From start to finish [19:51:56] Assuming you have the system dependencies installed [19:52:02] wait, let me just add it [19:52:28] That should be it [19:52:34] Let me know if you run into issues [19:52:49] x86_64-w64-mingw32 = windows 64 bit [20:59:33] sakdeniz@DESKTOP-M0SM1PJ:~/navcoin-core/depends$ make -j8 HOST="x86_64-w64-mingw32" Fetching protobuf-2.6.1.tar.bz2 from https://github.com/google/protobuf/releases/download/v2.6.1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 157 0 157 0 0 277 0 --:--:-- --:--:-- --:--:-- 277 100 612 0 [20:59:34] 612 0 0 702 0 --:--:-- --:--:-- --:--:-- 702 100 1974k 100 1974k 0 0 434k 0 0:00:04 0:00:04 --:--:-- 547k /home/sakdeniz/navcoin-core/depends/work/download/native_protobuf-2.6.1/protobuf-2.6.1.tar.bz2.temp: OK Extracting native_protobuf... /home/sakdeniz/navcoin-core/depends/sources/protobuf-2.6.1.tar.bz2: OK Preprocessing native_protobuf... Configuring native_protobuf... /bin/sh: 1: Syntax error: "(" unexpected [20:59:34] funcs.mk:251: recipe for target '/home/sakdeniz/navcoin-core/depends/work/build/x86_64-w64-mingw32/native_protobuf/2.6.1-23a2c793f2e/./.stamp_configured' failed make: *** [/home/sakdeniz/navcoin-core/depends/work/build/x86_64-w64-mingw32/native_protobuf/2.6.1-23a2c793f2e/./.stamp_configured] Error 2 sakdeniz@DESKTOP-M0SM1PJ:~/navcoin-core/depends$ [20:59:38] @mxaddict [21:02:55] I've not run into that error before [21:03:08] Can you run this: bash --version [21:03:26] sakdeniz@DESKTOP-M0SM1PJ:~/navcoin-core/depends$ bash --version GNU bash, version 4.4.19(1)-release (x86_64-pc-linux-gnu) Copyright (C) 2016 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software; you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. [21:14:11] Hmmm [21:14:37] 1 sec, I'll try and build make -j8 HOST="x86_64-w64-mingw32" and see if I get that issue [22:30:47] @sakdeniz [22:30:53] I did not get that error on build [22:31:17] Try building with this:make -j8 HOST="x86_64-w64-mingw32" VERBOSE=1 [22:31:24] So we can see more details of the error [23:56:58] merged https://github.com/navcoin/navcoin-core/pull/558 [23:57:21] what else do we need for 4.7.0 release [23:57:24] was there another one?