[02:11:41] @mxaddict when i try build the depends in your patch-5 branch (up to date) i get an error compiling unbound [02:11:52] https://cdn.discordapp.com/attachments/416000318149754881/574055564892700672/Screen_Shot_2019-05-04_at_2.10.40_PM.png [03:35:13] @prole thanks, I'll go see what's up [03:35:38] I think on my local machine I might have libexpat-dev install on the system [03:36:06] I'm assuming that libexpat is supposed to be included in the depends correct? [04:18:36] @prole I found the issue and am running the test suite on local after compiling, I will push once test suite passes [05:01:04] @prole @aguycalled [05:01:36] My latest push for that my branch mxaddict:patch-5 is now working on the linux builds [05:01:45] But I ran into an issue with the mac build on travis [05:02:04] I'm getting -Qunused-arguments error [05:02:15] But the configure step clearly checks checking whether C preprocessor accepts -Qunused-arguments... yes [05:02:36] Then it proceeds to fail with g++: error: unrecognized command line option ‘-Qunused-arguments’ [05:02:42] Any ideas what could cause this? [05:05:01] @Juguelio why is my discord name now orange? [05:47:57] I addd you to the "community dev" group [05:48:03] hence the orange username [05:48:05] Thanks @prole [05:48:32] gives you access to a couple extra dev channels under the admin channel group and a position on the right user list [05:49:37] doesn't really do much but its a token gesture of appreciation for the work you're doing 😃 [05:50:25] and sorry i dont know what that error you're getting is. i havent run into it before [05:50:36] maybe alex can help when he gets online [05:50:43] About the error, I think I found it 😄 [05:50:59] I've push a commit and waiting for travis to tell me if I'm correct [05:57:58] nice [06:46:40] i think for the most part my gitian problems were largely to do with the rc.lcoal not running [06:47:01] so the bridge was not setup [06:47:03] for lxc [06:52:28] so that all starts up [06:52:41] but im back to square one, same problem with my old gitian VM [06:52:55] it tries to build the dependencies and it just times out trying to curl the tar files [06:52:57] dunno why [06:53:25] i can curl them from the terminal of the debian VM im running gitian on, but gitian cant curl them [07:31:22] @aguycalled what do you think adding "fork warning" feature to the core wallet [07:32:54] if the wallet has been forked due to a technical bug/problem, I think it would be good to let it know with a warning. [07:34:31] @sakdeniz that's a good, idea, but how to determine which is the correct chain? 😃 [07:34:54] we can use it navexplorer's latest block number as master [07:34:56] @prole have a look at your network interface setup probably the vm does not have internet access [07:35:32] i dont like to rely on third parties, its adding an attack vector [07:36:06] @sakdeniz that's assuming that navexplorer has not forked 😄 [07:36:41] i assume navexplorer always up-to-date 😃 [07:36:50] Maybe checking the diff, and if diff drops X% then warn user that due to such a low diff, that might have forked 😄 [07:37:36] @aguycalled has a point, though we might trust the block explorer, it's still a third party [07:38:52] so do your backend for check latest block number [07:39:02] just a json file return with latest block number [07:39:39] i think it would be useful and necessary. [07:41:59] when such a problem occurs, they realize very late and they make less profit. [07:43:00] @aguycalled i can curl the same tar file from inside the debian VM, so it has internet access [07:43:06] but i will keep checcking [07:48:21] https://navpay-api.navcoin.org/bws/api/v1/status [07:48:27] there is already one ^ [07:49:46] secure end point for checking user's wallet is in correct chain [08:29:05] sounds like curl is trying to hit an invalid url [08:29:34] check syntax of whatever you are trying to download with curl [08:29:54] get debug output of the script actually running [08:30:23] if you can curl interactively from shell but something like a script won't curl, it's usually a problem with the curl syntax [08:31:07] networking is not selective per user [08:31:14] packets are packets [08:31:41] the only real system restriction is that non-root users can't execute services that listen on ports 1024 and below [09:12:40] @prole i mean the ubuntu vm gitian runs inside of debin to build [09:14:09] thats not a secure endpoint @sakdeniz its centralized and vulnerable to attacks [09:14:21] requires trust in navexplorer [09:14:48] i mean navpay api @aguycalled [09:15:00] sorry [09:15:09] navpay is centralized [09:15:28] core must be completely trustless [09:17:36] I understand, so we need to find a way to solve this in the core wallet. [09:36:28] @aguycalled what about just checking network diff? [09:36:53] If the network diff drops drastically, that's a good indication that you have left the main chain [09:49:06] But if many nodes crash on the same time, it will give a false alarm [10:10:45] @Goku Well, it's just a warning after all, and all you do after seeing the warning is check if you are on correct chain. [10:49:04] @prole @aguycalled https://github.com/NAVCoin/navcoin-core/pull/461 Should be ready for review [10:49:11] I'm just waiting on final travis build [11:15:17] 4.5.2 contains a hard fork which explicitly rejects blocks from obsolete versions (4.5.1 and below) signalled by version bit 21. How can there still be listed older versions in the navcoin block explorer (cryptoid) ? [11:20:11] they are forked [11:20:17] but still connected to the network [12:19:54] @prole @aguycalled [12:20:02] I'm getting The job exceeded the maximum time limit for jobs, and has been terminated. in travis [12:20:28] But the build is working and tests are passing, then it runs out of time (50) minutes [12:20:30] https://travis-ci.org/NAVCoin/navcoin-core/jobs/528121333 [12:20:38] Any tips on how to get this to build? [12:24:59] ill have a look after lunch [12:30:09] Thanks [14:22:27] looks like you already found the issue @mxaddict [14:22:33] was my test waiting for so many blocks [14:53:07] Yes, I turned it down to 3 blocks in stead of 20 and managed to get the build to run in under 50 minutes 😄 [14:53:45] I made quite a few changes in that branch, le me know if you wanna have anything changed/reverted [15:07:34] i will basically run gitian on your branch as a test [15:10:08] seeing you added some interesting things like the final report of ./configure [15:11:50] you've added some references to building for riscv, which is not incorporated yet in our flow. but i guess it does not hurt and we will end up adding it somewhen [15:12:59] everything looks good, let me just test it locally on a few systems + gitian and it'll get my approved seal [15:18:08] Roger that 😄 [15:18:25] I've only been able to test the wallet on windows and linux [15:18:30] I don't have a mac on hand [16:42:21] im on it rn [17:20:06] Great work @mxaddict! [17:20:34] Are you cleaning up on bounty tickets? [17:45:41] Actually I started out just wanting to fix some issues that were affecting me [17:45:51] When I found out I could get NAV for doing more issues [17:45:55] It was a no brainer 😄 [17:46:16] @prodpeak [17:51:31] The community appreciates the work you do! [18:28:53] gitian fails @mxaddict [18:30:05] https://cdn.discordapp.com/attachments/416000318149754881/574301738098491441/unknown.png [18:30:23] https://cdn.discordapp.com/attachments/416000318149754881/574301814103605269/unknown.png [18:31:31] when doing make -j2 -C src check-symbols [18:37:19] Ok, I'll check it out [18:38:03] same command worked in my osx, will try in my debian [18:42:57] That command worked fine on my machine [18:44:36] ./miner.h:Atglobalscope: ./miner.h:38:13:warning:‘fStaking’definedbutnotused[-Wunused-variable] staticboolfStaking; ^~~~~~~~ Infileincludedfrom./wallet/wallet.h:10:0, fromqt/walletmodeltransaction.h:9, fromqt/walletmodel.h:9, fromqt/navcoingui.cpp:24: ./mnemonic/mnemonic.h:38:15:warning:‘mnemonic_seed_multiple’definedbutnotused[-Wunused-variable] staticsize_tmnemonic_seed_multiple=4; ^~~~~~~~~~~~~~~~~~~~~~ [18:44:37] ./mnemonic/mnemonic.h:33:15:warning:‘mnemonic_word_multiple’definedbutnotused[-Wunused-variable] staticsize_tmnemonic_word_multiple=3; ^~~~~~~~~~~~~~~~~~~~~~ CXXqt/qt_libnavcoinqt_a-moc_rpcconsole.o ARqt/libnavcoinqt.a /usr/bin/ar:`u'modifierignoredsince`D'isthedefault(see`U') CXXLDqt/test/test_navcoin-qt OBJCXXLDqt/navcoin-qt make:Leavingdirectory'/home/mxaddict/Projects/mxaddict/navcoin-core/src' [18:50:54] working too [18:52:20] /contrib/devtools/symbol-check.py [18:52:49] this is what fails [18:53:15] MAX_VERSIONS = { 'GCC': (4,4,0), 'CXXABI': (1,3,3), 'GLIBCXX': (3,4,13), 'GLIBC': (2,11) } [18:53:22] maybe this need to be updated? @mxaddict [18:54:20] Hi @prole. I'm contacting you regarding CryptoBridge listing. We've got an application for listing NAV with your contacts on it. Can you confirm that you filled the application? Thank you. [18:55:23] @aguycalled ok, I'll update that [18:56:08] @aguycalled what versions are you running in the gitian server? [18:57:05] Or better yet, if you have a specific version in mind, then I'll add that. [18:57:51] gcc 4.8 [18:58:18] Is MAX_VERSIONS supposed to be MIN_VERSIONS [18:58:26] glibc 2.19 [18:58:29] no clue tbh [18:58:34] Haha [18:58:40] I'm confused a bit with the naming [18:59:01] did you change the versions used in your pr? [18:59:22] No, not that I remember [18:59:34] then we should not need to change them there [19:00:11] might be some of the changes you brought from upstream for linking [19:00:21] Yeah, might be, I'll check [19:00:42] bitcoin gitian runs ubuntu bionic [19:00:45] we are still on trusty [19:00:55] they use gcc 8 [19:01:07] Hmmm, but travis .yml is still trusty as well [19:01:14] And that build works [19:01:22] NVM, it does not call the check symbols [19:01:26] but probably travis does not run make check [19:01:33] yep [19:01:46] Yeah, I'll try to find the cause then [19:02:02] How easy is it to setup a local gitian so I can test? [19:02:08] Do they have a docker container? [19:02:33] https://github.com/NAVCoin/navcoin-core/blob/master/doc/gitian-building.md [19:02:46] Thanks [19:03:13] just go through the steps in order [19:03:38] ACK [19:03:42] 😄 [23:03:30] @sherlock-holmes yes i filled in your application form. I saw you list pivx and became interested in your service when i saw that users can run either cloud or local wallets. Am i correct in understanding that users can trade while keeping their private keys secure on their local machine? [23:27:03] @prole It's not a real DEX like bisq, and as far I understand you dont hold the private keys on your local machine. In forums are many bad experiences to read about.