[00:30:47] <navcoin-bot> <mxaddict> @aguycalled  I started getting cfund errors
[00:30:51] <navcoin-bot> <mxaddict> In my tests
[00:31:48] <navcoin-bot> <mxaddict> But I did not change anything related to cfunds, and I even tried reverting to a commit that I knew for sure that worked.
[00:31:53] <navcoin-bot> <mxaddict> Still getting the same issue
[00:35:09] <navcoin-bot> <aguycalled> which cfund tests?
[00:35:18] <navcoin-bot> <mxaddict> I think all of them?
[00:35:25] <navcoin-bot> <mxaddict> Wait, let me do a sanity check
[00:35:32] <navcoin-bot> <mxaddict> I'm building the master branch
[00:35:41] <navcoin-bot> <mxaddict> And will run the suite on that
[00:38:39] <navcoin-bot> <mxaddict> Looks like your build is getting the same errors
[00:38:57] <navcoin-bot> <mxaddict> assert (get_bip9_status(node, "communityfund")["status"] == "started")
[00:43:10] <navcoin-bot> <mxaddict> Yeah, looks like I'm not crazy after all, the error is persisting even when I built master branch
[00:44:03] <navcoin-bot> <aguycalled> mmm
[00:44:06] <navcoin-bot> <mxaddict> Could be a bug in the cfund code?
[00:44:39] <navcoin-bot> <mxaddict> Something timestamp related maybe, that would be the only explaination for it to start to fail just today
[00:44:45] <navcoin-bot> <aguycalled> can ypu tell me one concrete test you see failing?
[00:44:59] <navcoin-bot> <mxaddict> ./qa/pull-tester/rpc-tests.py cfund-proposalvotelist
[00:45:00] <navcoin-bot> <aguycalled> or is it all?
[00:45:34] <navcoin-bot> <mxaddict> It's anyting that is calling ./qa/rpc-tests/test_framework/cfund_util.py
[00:45:43] <navcoin-bot> <mxaddict> Basically the cfund fails
[00:46:14] <navcoin-bot> <mxaddict> From the looks of it, seems like all tests that use activate_cfund are failing
[00:46:36] <navcoin-bot> <mxaddict> And I'm testing with the latest master branch which I know was working just a few hours ago
[00:46:50] <navcoin-bot> <aguycalled> this is weird, as it was working
[00:46:51] <navcoin-bot> <aguycalled> yeah
[00:46:59] <navcoin-bot> <mxaddict> Looks like your build on travis-ci also failed with same issue
[00:47:37] <navcoin-bot> <mxaddict> Yeah, must be something that is timestamp related (Something that would cause the cfund to get rejected?)
[00:47:50] <navcoin-bot> <aguycalled> yes
[00:47:52] <navcoin-bot> <aguycalled> ok
[00:48:19] <navcoin-bot> <aguycalled> // Deployment of Community Fund         consensus.vDeployments[Consensus::DEPLOYMENT_COMMUNITYFUND].bit = 6;         consensus.vDeployments[Consensus::DEPLOYMENT_COMMUNITYFUND].nStartTime = 1493424000; // May 1st, 2017         consensus.vDeployments[Consensus::DEPLOYMENT_COMMUNITYFUND].nTimeout = 1556668800; // May 1st, 2019
[00:48:22] <navcoin-bot> <aguycalled> bingo
[00:48:28] <navcoin-bot> <aguycalled> nTimeout 😃
[00:49:08] <navcoin-bot> <aguycalled> ill move it to 1651363200
[00:49:11] <navcoin-bot> <aguycalled> 1/5/2022
[00:49:20] <navcoin-bot> <mxaddict> 😄
[00:49:21] <navcoin-bot> <mxaddict> Hahaha
[00:49:23] <navcoin-bot> <aguycalled> chainparams.cpp
[00:49:32] <navcoin-bot> <mxaddict> Will you merge that to maste now?
[00:49:51] <navcoin-bot> <mxaddict> So I can rebase based on master? Or should I make the change to my branch as well?
[00:50:18] <navcoin-bot> <aguycalled> yes ill do
[00:50:23] <navcoin-bot> <mxaddict> Thanks
[00:50:26] <navcoin-bot> <mxaddict> Wew
[00:50:37] <navcoin-bot> <mxaddict> For a few minutes I thought I was going crazy
[00:50:37] <navcoin-bot> <mxaddict> LOL
[00:51:48] <navcoin-bot> <aguycalled> done
[00:53:18] <navcoin-bot> <mxaddict> BTW, I finally figured out where the LOCK(cs_main) needed to be added
[00:53:24] <navcoin-bot> <mxaddict> I'm doing final testing now
[00:53:35] <navcoin-bot> <mxaddict> Then PR 450 should be ready for final review
[00:53:36] <navcoin-bot> <mxaddict> 😄
[00:53:47] <navcoin-bot> <aguycalled> great work
[00:53:56] <navcoin-bot> <aguycalled> 😉
[00:54:06] <navcoin-bot> <aguycalled> i'm happy you joined dev efforts!
[01:07:00] <navcoin-bot> <mxaddict> @aguycalled
[01:07:11] <navcoin-bot> <mxaddict> I think you might need to run certbot renew
[01:07:13] <navcoin-bot> <mxaddict> On https://build.nav.community/depends-sources/
[01:07:31] <navcoin-bot> <mxaddict> Certificate just expired
[01:08:03] <navcoin-bot> <mxaddict> Or if you have the certbot renew added to a crontab, will need to also nginx reload or apache2 reload
[01:14:11] <navcoin-bot> <aguycalled> done thx
[14:12:39] <navcoin-bot> <aguycalled> @mxaddict just for reference, the rpc test suite has a method to set a node time
[14:12:53] <navcoin-bot> <aguycalled> set_node_times
[14:13:12] <navcoin-bot> <aguycalled> i'm not sure how it will work with the ntp sync tho
[19:51:33] <navcoin-bot> <aguycalled> @mxaddict could you also leave a navcoin address for the bounty payments in the issues you are assigned
[20:30:46] <navcoin-bot> <mxaddict> @aguycalled  I commented on the issues with a fresh address 😄
[20:31:31] <navcoin-bot> <aguycalled> thx, ill send the coins tomorrow 😉
[20:31:55] <navcoin-bot> <mxaddict> Thanks for the tip about set_node_times
[20:32:26] <navcoin-bot> <mxaddict> I might be able to use that to test the getstakereport better
[20:48:24] <navcoin-bot> <mxaddict> @aguycalled Is anyone working on the show mnemonic and import mnemonic UI?
[20:48:31] <navcoin-bot> <mxaddict> If not, I might give it a shot.
[20:50:37] <navcoin-bot> <aguycalled> nope, should i assign it to you?
[20:56:07] <navcoin-bot> <mxaddict> Not yet, I'll have a look see first
[20:56:18] <navcoin-bot> <mxaddict> To see if I can actually get it done
[20:56:32] <navcoin-bot> <mxaddict> @aguycalled
[21:43:06] <navcoin-bot> <prole> I've approved and merged #459 and #450
[21:43:18] <navcoin-bot> <prole> looking at #456 now
[21:43:32] <navcoin-bot> <prole> then will pull master into rc PR
[21:44:58] <navcoin-bot> <prole> ah #456 has conflicts with master now
[21:46:17] <navcoin-bot> <prole> i can resolve it, its just the maturity param added to the devnet chainparams
[21:53:22] <navcoin-bot> <prole> Just wondering what our procedure for an approved PR should be. E.g. often we (myself included) approve a PR with no comment. I think we should get into the habit of documenting what we did to approve it. Eg. did we eyeball the diff, did we code review the changes in context, did we compile successfully, did we run the relevant unit tests, did we manually test the patched scenario, did we smoke test other features to make sure normal
[21:53:23] <navcoin-bot> wallet functions remain working? etc..
[21:54:58] <navcoin-bot> <prole> thoughts?
[22:00:13] <navcoin-bot> <mxaddict> @prole Not sure, I don't have much experience with opensource projects But at my desk job we have a small check list 1. Eyeball the merge 2. Review indepth if the changes are more than 5 lines 3. Make sure all test cases pass (Sometimes we have manual tests) 4. Approve/Reject based on results from 1 - 3
[22:00:59] <navcoin-bot> <mxaddict> The manual tests are usually just for stuff that can't be automated like GUI or UX
[22:43:06] <navcoin-bot> <mxaddict> @prole looks like the lastest build for PR#456 has an issue with cfund-paymentrequest-state-reorg.py