[03:34:33] Greetings @prole . Payment request is missing the "P" 4.6.0 Tried stretching the screen, but no go. [03:38:38] Fatal error with an empty wallet, and clicking "Your vote" [03:38:39] https://cdn.discordapp.com/attachments/416000318149754881/572265462977527818/4.6.0.png [03:40:38] navcoin-4.6.0-x86_64-linux-gnu.tar.gz [03:48:50] albiet - wallet was still syncing. [04:19:45] After fully synced. [04:19:46] https://cdn.discordapp.com/attachments/416000318149754881/572275808228343809/after_sync.png [04:52:05] "Create Payment Request" missing beginning and end characters. [08:36:43] @roast , I have the same UI issue on my linux machine, I think the letters are actually correct, just the size of the font is too large and so it's getting cut off. [08:37:24] @prole I was not able to get to test the new merge request (Got busy on the weekend with family visit) [08:37:38] I will do it today and add feedback to the merge request on gitlab [12:53:36] I checked the latest code on master [12:53:52] Seems that the changes on master fixed both issues I was having. [13:02:10] So both issue https://github.com/NAVCoin/navcoin-core/issues/445 and issue https://github.com/NAVCoin/navcoin-core/issues/446 and fixed for me on master branch. [13:02:23] I think the fixes on merge request #447 fixed both issues. [13:03:05] BTW, I can't seem to compile the navcoin-qt binary [13:03:40] I folled instructions from: https://github.com/NAVCoin/navcoin-core/blob/master/doc/build-unix.md But the configure script can't find QT [13:09:11] Also when I build/make the depends DIR, I get this: make ✔  master Checksum missing or mismatched for qt source. Forcing re-download. Fetching qtbase-opensource-src-5.7.1.tar.gz from http://download.qt.io/official_releases/qt/5.7/5.7.1/submodules % Total % Received % Xferd Average Speed Time [13:09:11] Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 Not Found Fetching qtbase-opensource-src-5.7.1.tar.gz from https://build.nav.community/depends-sources % Total % Received % Xferd Average Speed Time Time Time Current Dload [13:09:12] Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 Not Found funcs.mk:245: recipe for target '/home/mxaddict/Projects/mxaddict/navcoin-core/depends/sources/download-stamps/.stamp_fetched-qt-qtbase-opensource-src-5.7.1.tar.gz.hash' failed make: *** [13:09:12] [/home/mxaddict/Projects/mxaddict/navcoin-core/depends/sources/download-stamps/.stamp_fetched-qt-qtbase-opensource-src-5.7.1.tar.gz.hash] Error 22 [13:15:54] Cool @mxaddict! if you have any plans to build for NAV...remember there's a community fund waiting for you! [13:18:47] Hahaha [13:19:03] I'm here for the fun of it [13:19:16] But FREE nav for work I would have done anyway is good 😄 [13:20:36] @Juguelio , I see that there are tags in gitlab repo with bounty in the name, can you explain what those mean? [13:21:22] Those tasks will pay the resolvers through Alex's bounty programme. [13:21:33] I see [13:22:54] I was only able to test the fixed for issue #445 and 446 via CLI, cause I was unable to build the GUI (I'm guessing because of the depends DIR make command not working. [14:36:11] i'm also having issues to build the gui on my osx [14:36:43] i opted for building without gui by now as i have some urgent things to look at [14:36:56] but this could be considered an issue if you also see it [14:37:20] im seeing lots of error: function-like macro 'QT_CONFIG' is not defined [14:37:33] @mxaddict [14:38:43] I'm still building as of now, seems to be fine so far, I'll let you know If I run into any issue. [14:42:40] @aguycalled , I was able to build GUI fine [14:42:47] No errors like you said. [14:42:57] Might be an OSX only issue? [14:43:26] I don't have a MAC anymore (Not for almost a decade now) so I can't test. [14:49:13] @aguycalled , I have a question about the "staking report" [14:49:28] Seems on a wallet.dat with a "spend" address, the staking report is correct. [14:50:03] But on a wallet.dat with only a "stake" address, the report justs says 0.00 [14:52:17] Is this by design? My issue https://github.com/NAVCoin/navcoin-core/issues/446 was about it showing negative values, in the current master branch, it's showing 0.00 which is technically correct, since the stakes are for the spending address, but it would be neat to see the stake report in the stake only wallet as well (I mean convenient) [14:52:49] Cause the way it is now, though technically it's correct to say 0.00, is inconvenient. [14:53:12] Cause to see the proper stake report, you will have to open the spending wallet [17:44:16] 8 connections, fully synced, virgin wallet. [17:44:17] https://cdn.discordapp.com/attachments/416000318149754881/572478271820660746/fatal.png [17:47:18] navcoin-4.6.0-x86_64-linux-gnu.tar.gz [17:54:13] @roast that does not seem to happen to my wallet (With transactions and some votes) [17:54:39] Might be some code that does not handle a wallet with no previous votes (Gracefuly) [18:26:04] Agreed [18:32:30] @prole and @aguycalled I've created PR https://github.com/NAVCoin/navcoin-core/pull/450 that fixes both 446 & 445 it seems that 447 only moved the issue from one wallet scenario to another. I have a full explanation of the issue in the PR [18:33:06] Let me know what you think [18:52:31] looks good, haven’t tested yet as i’m busy assisting exchanges with wallet maintenance [18:53:30] if you add an rpc test for getstakereport you will earn the bounty 😉 [18:53:49] which is a double bounty because you solve two issues [18:53:57] Ok, will add as soon as I get home. [18:54:14] I'm on mobile right now. [18:54:46] How difficult is it to compile the wallet on windows? [18:57:17] ive never done it [18:57:31] only through gitian [18:59:12] Ok, i'll stick to Linux then. [18:59:52] My PC at home is windows so I have to reboot 😂 🐷 [19:17:39] @aguycalled, can you point me into the direction of the dir with tests for RPC functions? [19:39:03] qa/rpc-tests [19:53:14] https://github.com/NAVCoin/navcoin-core/blob/master/src/test/rpc_tests.cpp ? is this still used? [19:53:52] Ok, so I'm guessing the /src/tests is no longer maintained? [19:57:37] part of the nz team started to work on reenabling the c++ test units before the team downsized [19:58:49] some of them are working [19:58:59] most are not ported from bitcoin [20:07:38] I see [20:09:09] I'll see if I can figure out on my own how to create test data [20:09:14] If not I will ping you here 😄 [20:09:38] I'll add the test to the /qa DIR [20:11:13] quick question, when I run a test via qa/pull-tester/rpc-tests.py does that compile the navcoind form /src? or will I have to manually compile before running the test? [20:12:09] nope does not build [20:12:22] just runs the rpc test which spawns a daemon and does what the test says [20:14:30] Ok [20:15:04] Is there a test case where I can see how test data is created? [20:15:12] Cause I would like to test 3 scenarios [20:15:54] 1. Spending Wallet (With a few stakes) 2. Staking Wallet (With a few stakes) 3. Wallet with both the spending and staking address imported from scenario 1 and 2 [20:16:46] brb 1h [21:09:40] what do you mean with test data? @mxaddict [21:09:57] in the context of getstakereport [21:14:29] I mean, I want to create 2 addresses that have old stake data, that I can assert as having been calculated correctly in the stakereport [21:14:54] I would need atleast 3 stakes in each address [21:15:16] you are testing using rpc commands, so basically thats what you use [21:15:20] And the addresses would be as follows, spending, staking and cold (Created from the spend and stake) [21:15:42] Hmmmm, there is no way to make a testchain with preset data? [21:16:26] you start with a virgin chain and generate 300 blocks to activate soft forks using the rpc command generate [21:16:37] Ahh, I see [21:16:53] you will have 60mill coins which you can distribute to addresses [21:16:59] and then just wait until it stakes [21:17:00] Is there a test file that does something similar to what I need? 😃 [21:17:11] So I can study it, then make my own based on an existing one? [21:17:30] i will check 😉 [21:17:34] Thansk [21:18:07] the cfund-* tests should be easy to read [21:18:26] but i will look for some specific which waits for staking [21:18:34] im not sure if theres one tbh [21:19:04] Ok, I'll comb the cfund stuff for now [21:20:14] try the coldstaking* tests [22:19:57] I wrote the static rewards staking amount tests [22:20:06] it waits for new blocks to be generated [22:20:06] https://github.com/NAVCoin/navcoin-core/blob/master/qa/rpc-tests/staticr-staking-amount.py [22:20:09] by staking [22:21:04] it's reasonably straight forward, just store the blockcount and then enter a while loop to wait for the desired height [22:21:21] blockcount = self.nodes[0].getblockcount() wallet_info1 = self.nodes[0].getwalletinfo() # wait for a new block to be mined while self.nodes[0].getblockcount() == blockcount: print("waiting for a new block...") time.sleep(5) assert(blockcount != self.nodes[0].getblockcount()) [22:22:07] you can probably write something similar to do what you need. [22:22:41] if you need the stakes to be created by different nodes, then you'll need to make sure you distribute the coins evenly to give a good chance of each one generating a stake i guess [22:28:52] Thanks @prole [23:12:44] @prole @aguycalled so I have created a test [23:13:19] For now all it does it stake 1 block, generate some blocks to mature the stake [23:13:28] So it shows in the getstakereport [23:13:55] And then repeat that another time and confirm that the "Last 24H" value in the stake report is correct [23:14:15] But I want to make the test span atleast to the "Last 7 days" part of the report [23:14:26] Is there a way to more time forward in the test chain? [23:14:37] So that the next stake will be 7 days in the future? [23:15:18] modifying your system time [23:15:31] and deactivating ntp sync [23:15:41] dont know if it is possible [23:15:45] Hmmmm [23:15:51] but its the only way [23:15:58] I thought so [23:16:12] The whole wallet is designed to not be tricked by time changes [23:16:15] LOL [23:16:45] My test is running 3 nodes [23:17:01] Is there a way to disable ntp on all nodes? [23:17:19] you could use propose a change for devnet in chainparams.cpp [23:17:23] for maxfuturedrift [23:17:30] and put something extreme [23:17:48] so you can tamper the block timestamp [23:18:14] running the node ntpminmeasures=0 [23:19:54] But won't that affect the other tests? [23:20:12] I mean if I made changes to the chainparams.cpp for devnet [23:30:39] depends if there is any test reliant on the params you change [23:31:50] i have not tried to break the laws of relativity using navcoind yet sorry [23:32:13] 😆 [23:35:43] 😄 [23:35:53] I know what you mean, LOL