[00:00:19] Can we merge your rpc PR and this gui update @aguycalled ? [00:02:20] https://github.com/NAVCoin/navcoin-core/pull/368 1 approve missing here [00:03:26] oh right we need two now [00:04:07] @aguycalled @mc290 @prole Where can I best direct my energies now? I'm done testing the things I had on my plate [00:04:27] building, changelog, preparing release [00:04:34] text for notifying exchanges [00:07:25] caught up with Craig, I'm going to run another kind of test on the hardfork [00:07:37] using devnet and two nodes [00:07:58] Craig is going to start on what you just mentioned [00:08:09] After my test I'll look into the changelog [00:08:50] i tried to write a unit test this morning to cover the reject obsolete block after the fork, but its gonna take me too long to get it working [00:08:57] so matt's gonna just manually test with two nodes [00:09:05] to verify it's working [00:09:31] ill draft the navcoin.org notice and let the exchanges know theres a hardfork happening at block x and the wallet will be availalbe tomorrow [00:10:06] Do we want the exchanges to disable deposit / withdrawal for the day of the hardfork just as a precaution? [00:14:26] i tested manually and worked, but worth to have it tested by someone else too [00:14:39] yes, better safe [00:14:52] okay [01:06:57] I;m not sure why cfund-proposal-state-accept.py is failing randomly https://travis-ci.org/NAVCoin/navcoin-core/jobs/468772221 [01:07:45] it is the assert statement after invalidateblock() [01:07:51] so it should be [01:09:54] assert(status_is_"expired-waiting-for-end-of-voting-cycle") invalidateblock() assert(status_is_"accepted") [01:11:04] i'm running it on loop locally and it hasn't failed once out of 8 times [01:14:45] @prole should I start drafting some release notes [01:15:27] sure [01:15:39] ive pre-warned all the exchanges that a new version is coming [01:15:44] with a fork before friday [02:11:37] I've created the draft notice for navcoin.org https://github.com/NAVCoin/navcoin-org/pull/130 [02:11:53] links to the release notes and the release tag are broken until we publish it [02:21:00] the fork appears to work [02:21:34] I had two nodes, one 4.5.1 and one 4.5.0, and when they hit block 1000 (fork height in dev net) 4.5.1 node stopped accepting blocks from 4.5.0 [02:39:27] https://github.com/NAVCoin/navcoin-core/pull/371/files#r242012616 [02:46:28] https://github.com/NAVCoin/navcoin-core/pull/375 any feedback welcome [02:58:45] looks good [03:27:23] https://github.com/NAVCoin/navcoin-core/pull/370 Should we merge this [08:04:44] So I believe we're all merged and Travis is passing. [08:05:04] The changelog commit broke Travis though [08:05:35] I had a look at that test and there's some shady stuff going on in there. We'll need to refactor how it works [08:05:43] But it will take some time. [08:05:57] Main issue is float math dealing with decimals being inconsistent [08:06:18] I'll run the guys through how to do satioshi int math in the morning [08:07:23] I don't think it should stop the release. [10:03:19] @prole so is it master ready to build? [10:14:15] Just the release notes to merge in. But it made Travis fail randomly for some reason [10:15:22] Master passed travis [10:15:32] With the code changes merged in. [10:16:07] So just depends what you think we should do about the test failing on the release notes pr. [10:16:48] I think we need to review and refactor that test so it's more robust, but I don't think it should hold back the release. [10:17:19] So I'd probably just merge it then if Travis fails, rerun Travis and the test will probably pass [10:17:55] It's only failing due to float rounding being off by some small decimal places from what I can tell [10:18:54] And then kick off a gitian build so we can smoke test and cut the release in our tomorrow morning [11:02:47] yes this should be out asap [19:50:33] seen u just merged, ill start gitian building @prole [19:50:40] yep [19:52:05] @mc290 @Matt (Dev) if you guys can kick off gitian builds also that would be great [19:52:13] my gitian VM still isnt compiling [19:54:36] Will do [19:58:52] ok [20:25:16] Travis succeeded [20:25:19] On master [20:56:53] cool, my gitian is going a bit slow. i reduced specs, i was paying hundreds per moth in vsps [21:43:28]

https://cdn.discordapp.com/attachments/416000318149754881/524340881055023125/coldstaking_spending.py [21:44:35]

@prodpeak @dy5es41 @Hayden Can you guys check if this returns True for you? This is the fix I put on my branch before. [21:48:54] I'm away from my computer until tomorrow morning UTC. [21:49:28]

No worries I accidentally tagged you ahah [21:49:46] I would have ran it for you :) [21:58:50] http://178.128.55.160/master/ built [22:24:01] okay, lets check this against other hashes once theyre built [22:24:11] i have a gitian build running on my VM now [22:24:33] 8GB of RAM allocated 💪 [22:47:28] do you have to restart navcoind after updating navcoin.conf when adding new voting for additional proposals? [22:48:33] if you add them through the config manually, then yes, that file gets put into memory when the program starts [22:48:53] if you use the rpc commands then no, because it will add it to the config file and also write it to memory for you [22:49:13] ok. i need to figure out the rpc commands [22:49:30] because i normally just fire up NEXT and vote there, then copy the config to navcoin.conf on my navpi [22:50:58] voteproposal HASH yes/no votepaymentrequest HASH yes/no [22:51:01] should be those [22:51:12] talking to the rpc will be the annoying part [22:54:17] https://medium.com/@NAVCoin/navcoin-wants-you-to-vote-90cd4fc933bb [22:54:34] theres voting instructions for the navpi there [23:04:31] if you are talking about navpi, the php already has a rpc interface iirc @mntyfrsh [23:05:14] i know that. where's the link to writeup to setting voting on navpi? [23:05:50] https://cdn.discordapp.com/attachments/416000318149754881/524361611142758430/Screen_Shot_2018-12-18_at_12.05.36_PM.png [23:05:57] its on that medium article i just linked [23:06:03] $coin->proposalvote($HASH,"yes"); [23:06:05] that should work [23:06:17] let me find the medium article link [23:06:20] https://info.navcoin.org/knowledge-base/voting-for-a-community-fund-payment-request/ [23:06:26] nice thanks