[02:14:58] In PR#370 Fixes Payment Request payout when Proposal is expired, i noticed if a proposal expires and goes to the new "pending" state, i can still make new payment requests [02:15:56] i've modified the test and I think i found the cause, rebuilding now [03:18:54] im making this branch now and having a look [03:20:52] what do we need to test for the 4.5.1 fork branch? [03:22:17] transactions dont need to be tested right? just that the block has the right version? [03:28:29] and we assume if they have the right block version, that they are computing the correct data for the cfund [03:30:53] is there something we need to test where someone is sending the correct block version, but has the old data structure for the cfund? [03:38:04] this PR is just the test I added which fails https://github.com/aguycalled/navcoin-core/pull/47 @aguycalled @prole [03:40:28] otherwise I've tested this branch and it fixes the bug. It just has the unintended effect that I can continue making payment requests [03:44:33] the cause I think is because in main.cpp, CountVotes(), even though we update fState = PENDING_VOTING_PREQ; we do not update it because this conditional branch is missing fUpdate = true; so the proposal will stay in fState of ACCEPTED [03:45:18] I tried adding fUpdate = true; but it has some run on effects and it breaks the tests in other places [03:47:45] im about to fall sleep, 5am here. lets catch up later, but feel free to submit a patch, it makes sense what u say [03:48:01] wow alex did you stay up all night [03:48:16] good night/morning [05:59:23] I'm out at the mo @mc290 [05:59:45] But I'll be working on this tonight (about 1 hour from now until midnight or so) [05:59:58] Then I'll be in the office in the AM [06:00:12] Happy to patch, review, test etc [06:34:17] Ok me too [08:21:08] Do you want to write the patch for the test you wrote that fails? or do you want me to have a crack at it? [08:28:20] i'm having a go at it now [08:28:57] but i'm not sure if it's the right way. I'm trying to keep it simple and not change too much code but one thing leads to another... [08:29:11] let you know how it goes [08:29:20] okay, ill focus on something else [08:29:31] just let me know if i can help [08:32:40] ok [09:04:09] https://github.com/aguycalled/navcoin-core/pull/47 with patch @aguycalled @prole [09:05:18] it might not be the best way to fix it. also need to wait and check travis result is ok [09:05:33] can someone else help me check it? [09:18:38] sure, ill check it [09:24:02] building your branch now [09:39:34] looks good @mc290 [09:39:41] lets wait for travis to end [09:52:15] ive compiled and run your test which passes. [09:52:48] the code makes sense from what i understand, but i haven't spent enough time looking at it in context. [09:52:54] i agree, lets see what travis says [10:08:37] only thing i think is missing in the test is checking if the state is correctly reversed when a block is invalidated [10:11:58] i think that would fail [11:03:36] im fading. gonna have to get some sleep [11:03:42] so i can start fresh tomorrow [11:04:24] left another comment on the 4.5.1 PR just in regards to what else we need / want to test on that [11:05:37] ortherwise ill look at #368 and #374 and see if we can sqeeze them in [11:06:10] and we'll look to get everything merged and building tomorrow if there's no more issues found [11:29:55] 370 looks good [11:34:49] will manually test 451 now [18:00:21] @aguycalled I noticed yesterday that on my accepted payment request, the voting cycle will continue to increment and its state will eventually be rewritten as expired. Not sure if this will cause issues as well [18:14:28] was it on my updated branch? [18:24:25] Before your latest commits [18:39:21] will try to replicate [19:03:59] fixed @mc290 [19:18:55] Ok I will check this morning [19:23:59] I'm on my way into the office now, will be there about 9 [19:24:03] Hello, was trying to build NavCoin-Core on macOS Mojave, getting error bool operator()(const CTxMemPoolModifiedEntry &a, const CTxMemPoolMo... any idea why? Thanks in advance [19:24:13] Which branch [19:24:17] Master [19:24:28] Should I take a tag? [19:24:36] Is there more to the error than that [19:25:01] Yes [19:25:08] I even copied wrong line [19:25:11] Code on master should compile at all times so doesn't really matter but it might not be 100% stable [19:25:28] ./miner.h:89:10: note: candidate function not viable: 'this' argument has type [19:25:34] This is where it goes wrong [19:25:46] If you want a stable version I suggest using the latest release tag [19:26:01] Hmm [19:26:35] I'll need to look at a bigger stack trace [19:26:44] Minute [19:27:02] https://cdn.discordapp.com/attachments/416000318149754881/523944159380373524/log.txt [19:28:44] Mmm I'm not sure I'm afraid. I might be able to take a closer look when I'm in front of my laptop [19:28:56] Kind of painful to do this on my phone [19:29:21] Yeah know that pain. Don’t worry. I’m not in a rush [21:17:23] @aguycalled i couldn't replicate the accepted preqs expiring [21:17:38] so i just added a test to be sure https://github.com/aguycalled/navcoin-core/pull/48 [21:40:10] waiting for gitian [21:41:42] I'm checking the cfundstats fix [21:41:51] compiling it now [21:55:31] in case anyone needs a testnet bootstrap https://drive.google.com/open?id=1l3ZDCZzoUALabgY-z1hn86zd5Rc34nVp [22:29:14] travis fails cfund-proposal-state-accept.py @mc290 [22:29:40] ok checking [22:30:02] the cfundstats fix looks good @aguycalled [22:40:19] @aguycalled I tested your cfund gui fix [22:41:10] What I cant test is if it will open the dialouge when payment reqs are detected [22:41:47] because the dialog only shows once a day right [22:41:50] or am I mistaken [22:42:18] if ((fFoundPaymentRequest || fFoundProposal) && !this->fDontShowAgain && (this->lastDialogShown + (60*60*24)) < GetTimeNow()) { [22:43:34] yep [22:43:43] you can restart the wallet and itll popup [22:45:43] I'm on regnet :p I don't think testnet will sync for me [22:45:49] I'll try marcus' bootstrap [22:50:35] you can try devnet [22:51:29] can you send me some coins on there too? [22:51:47] devnet does not exist [22:51:52] it just persistent on disk [22:51:59] and u can generate coins with generate [22:52:01] oh ok [22:52:09] sweet [22:55:27] dev net is syncing with someone lol [22:55:32] it's connected to a 4.1.0 node [22:58:28] lol nvm I launched with the wrong arg [23:13:45] @Matt (Dev) https://travis-ci.org/aguycalled/navcoin-core/jobs/468770139 [23:14:25] @aguycalled can you restart this build [23:14:33] I thought I could but I can [23:14:38] done [23:14:46] I want the tests to rerun and see if they fail agian [23:14:54] cheers [23:59:12] ok it works [23:59:17] the cfund gui changes