[00:00:11] <navcoin-bot> <aguycalled> we need to release 4.5.1 with a fix and ask everyone to upgrade
[00:00:16] <navcoin-bot> <aguycalled> @prole
[00:02:28] <navcoin-bot> <prole> okay
[00:04:09] <navcoin-bot> <Matt (Dev)> We should write a test that checks that the expiry time doesn't change
[00:04:14] <navcoin-bot> <aguycalled> yes
[00:04:47] <navcoin-bot> <aguycalled> ill get in bed soon, its more than 1am here
[00:04:56] <navcoin-bot> <Matt (Dev)> I have to go for a lunch date in a bit but @mc290 will be back soon
[00:05:55] <navcoin-bot> <Matt (Dev)> Looks good to me but we should test this
[00:06:06] <navcoin-bot> <Matt (Dev)> I will kick off a build
[00:07:04] <navcoin-bot> <Matt (Dev)> building now
[01:40:28] <navcoin-bot> <mc290> @aguycalled @prodpeak @Matt (Dev) with the patch, the proposals will loop for me on regnet
[01:41:22] <navcoin-bot> <mc290> after the proposal expire on regnet, they are reaccepted immediately on the next voting cycle. can somebody else please check?
[01:41:49] <navcoin-bot> <mc290> without reindexing or reopening the wallet
[01:44:24] <navcoin-bot> <mc290> i think this patch might have broken this fix https://github.com/NAVCoin/navcoin-core/commit/afd4bb2ba1300a73fbf2aa2fdcbf0592e17c49ec https://github.com/NAVCoin/navcoin-core/issues/290
[02:14:15] <navcoin-bot> <Matt (Dev)> expires on 1542338990
[10:11:00] <navcoin-bot> <aguycalled> @Matt (Dev) https://github.com/NAVCoin/navcoin-core/pull/367
[10:21:56] <navcoin-bot> <Matt (Dev)> looking at this now
[10:24:28] <navcoin-bot> <Matt (Dev)> code seems to make sense
[10:24:35] <navcoin-bot> <Matt (Dev)> I'll run a build
[10:30:37] <navcoin-bot> <Matt (Dev)> whats the word, code ACK :p
[10:31:05] <navcoin-bot> <aguycalled> mm my tests are failing
[10:31:22] <navcoin-bot> <Matt (Dev)> rpc tests?
[11:22:04] <navcoin-bot> <nico1987> Hello, don´t know if I rigth here, but I updated my naccoin core desktop wallet ago 2 days to 4.5. Now it shows me 8 active connections and it's syncing, but nothing happens. It is two days in arrears. I never had more connections than 8. It also normal. But nothing happens. What is the problem? Please help
[11:23:32] <navcoin-bot> <nico1987> It stands at block 2693154
[11:38:49] <navcoin-bot> <aguycalled> try bootstrapping
[16:45:06] <navcoin-bot> <aguycalled> https://github.com/NAVCoin/navcoin-core/pull/367
[16:45:36] <navcoin-bot> <aguycalled> @prole @Matt (Dev) @A-B @mc290
[16:45:39] <navcoin-bot> <aguycalled> this works for me, includes a test
[16:45:49] <navcoin-bot> <aguycalled> could you review and approve if applicable?
[16:48:55] <navcoin-bot> <aguycalled> some of the proposals which just got accepted have a very short duration of 1 week, so this bug can hit mainnet in 1-2 weeks
[16:50:01] <navcoin-bot> <aguycalled> wondering if we should kick off old versions from some block height
[18:19:01] <navcoin-bot> <Matt (Dev)> Morning
[18:20:13] <navcoin-bot> <Matt (Dev)> Why do we need to kcin off old versions
[18:25:24] <navcoin-bot> <Matt (Dev)> Actually I'm going back to sleep for a few more hours. My alarm went off at the wrong time and I'm pretty tired
[18:41:05] <navcoin-bot> <aguycalled> because someone could create a payment request for a proposal which some nodes see as accepted as some as expired
[18:41:10] <navcoin-bot> <aguycalled> causing a fork
[20:02:24] <navcoin-bot> <mc290> hi guys i am testing now
[20:34:46] <navcoin-bot> <mc290> Ok the proposals are expiring properly now
[20:35:51] <navcoin-bot> <mc290> And I reindexed testnet and the old proposal did not reappear nor did it get stuck reindexing
[20:36:26] <navcoin-bot> <mc290> I think at least one other person should double check
[20:36:42] <navcoin-bot> <aguycalled> cool
[20:36:44] <navcoin-bot> <aguycalled> i found another bug
[20:37:16] <navcoin-bot> <aguycalled> when static rewards is active and a block includes a tx all the blocks are rejected
[20:39:18] <navcoin-bot> <LordNelsson> That does sound like a pretty huge bug 😳
[20:41:01] <navcoin-bot> <aguycalled> https://github.com/NAVCoin/navcoin-core/pull/369
[20:41:11] <navcoin-bot> <aguycalled> @prole @Matt (Dev) @A-B @mc290
[20:45:26] <navcoin-bot> <aguycalled> we need to put out 4.5.1  soon
[20:48:22] <navcoin-bot> <mc290> I found another bug but I haven't tested it properly yet
[20:49:04] <navcoin-bot> <mc290> When a payment request is made it should be valid even when the proposal is expired right? 8weeks life
[20:49:36] <navcoin-bot> <mc290> But now when a proposal is expired the payment request will not pay out
[20:50:08] <navcoin-bot> <mc290> It will change to status "accepted waiting for end of voting period" then revert to pending on the next cycle
[20:52:48] <navcoin-bot> <aguycalled> yes, as long as the payment request was created while the proposal was not expired
[21:00:46] <navcoin-bot> <mc290> I am testing on regnet and I think because the locked funds are reverted on a proposal's expiry, the payment request will not be accepted even if it has enough votes
[21:01:26] <navcoin-bot> <mc290> Went out for breakfast, haven't tested fully yet sorry
[21:09:57] <navcoin-bot> <aguycalled> working on a fix
[22:33:30] <navcoin-bot> <aguycalled> https://github.com/NAVCoin/navcoin-core/pull/370
[22:33:42] <navcoin-bot> <aguycalled> @mc290 @prole @Matt (Dev) @A-B
[22:58:06] <navcoin-bot> <aguycalled> https://github.com/NAVCoin/navcoin-core/pull/371
[22:58:08] <navcoin-bot> <aguycalled> @prole
[23:02:47] <navcoin-bot> <Matt (Dev)> when does the fork happen
[23:03:51] <navcoin-bot> <Matt (Dev)> @aguycalled
[23:04:01] <navcoin-bot> <aguycalled> in 6 days
[23:04:11] <navcoin-bot> <aguycalled> before the proposals expire
[23:04:24] <navcoin-bot> <Matt (Dev)> Right
[23:04:37] <navcoin-bot> <Matt (Dev)> Which of these PRs have been tested
[23:04:49] <navcoin-bot> <prole> I'll start reviewing the PRs and testing this
[23:07:36] <navcoin-bot> <Matt (Dev)> I'm late to go meet my girlfriend so I'll have to review this stuff in a few hours :/