[00:35:12]

sometimes the tests will generate an extra block [00:35:27]

because the balance will change by 50 on some tests [00:35:49] that will definitely mess things up [00:36:08]

yeah. not sure as to why thats the case tho [00:42:27] Will have a PR up that adds these soon [00:42:28] https://cdn.discordapp.com/attachments/416000318149754881/521486820719067136/unknown.png [00:42:54] I've just copied and tweaked the ones from Bitcoin [00:44:42]

ok that makes sense what @aguycalled is saying that the min_fee change is related to the age of the outputs the tx spends. if an extra block is sometimes being generated in tests that would affect the age of tx outputs and hence the fees [00:44:50]

@mc290 @Matt (Dev) [00:49:38] Yes 100% [01:39:33]

Ok so the balance will change between tests by 50 but it looks like the blockcount remains constant [01:39:47]

@Matt (Dev) @mc290 [01:41:25] can you detect when the balance gets that extra 50 [01:42:02]

ok ill look to detect that [01:42:34] i say just make the tests check for range within 50 + 1 (i.e. BLOCK_REWARD + MIN_TRANSACTION_FEE) [02:04:35]

https://www.diffchecker.com/qARWEmWP [02:07:20]

@mc290 @Matt (Dev) log on the left is common case log on right is common balance - 50 [03:21:35] https://github.com/NAVCoin/navcoin-core/pull/348 @mc290 [03:21:39] can you look at this [03:37:55] I've restarted the builds for Alex's two PRs [03:38:07] If they pass I think we can merge them and keep this ship moving [03:38:52] https://github.com/NAVCoin/navcoin-core/pull/343 https://github.com/NAVCoin/navcoin-core/pull/342 @mc290 @A-B @prole Can we get some eyes over them in the meantime [03:40:48] I can't get the reject-version-bit test to fail locally. It's failure or passing must have something to do with the environment the test runs in 🤔 [04:14:07]

Ran 5x locally. Passed each time [04:14:12]

@Matt (Dev) [04:14:50]

for reject-version-bit [04:17:09] Alex's PRs both fail reject-version-bit. Interestingly the test passes on some builds and fails on others [04:17:18] So it's failing on some strange condition [04:18:15] Restarting the builds to see if something changes [04:18:33] I think to get to the bottom of this we need to dig into the sync_all function [04:21:08]

Do you think that has something to do with why coldstaking_spending.py tests had certain differences in debug log concerning wallet loading and clock syncing? [04:21:42] I would think they are necessarily related [04:21:45] t [04:21:57]

Alright [06:05:00] ive looked at these PR's they seem fine. I'm happy with them as long as travis builds pass etc [06:06:22] do we want to try and get this in for 4.5 as well? https://github.com/NAVCoin/navcoin-core/pull/350 [11:04:03] I think so [17:59:38] travis was passing [17:59:40] so i merged [17:59:44] but now travis fails on master [18:00:12] reject-version-bit.py fails [20:30:41] This test is driving me nuts [20:30:50] By the way can we put out a call for translations [20:31:06] see if we can get some new lines in while we try fix this test [20:33:16] @Matt (Dev) you can communicate regarding translations with me. If there will be just several lines, no problem at all [20:34:30] https://www.transifex.com/navcoin/navcoin-core/ [20:34:39] Have you seen this before @Igors Fridkins [20:35:58] Yes, also worked with json files. If there will be instruction I can manage all translators [20:45:25] I haven't actually looked at the transifex stuff before, I just know that's what we use for the core wallet [20:45:43] But if you translate using that website it should end up in the core wallet [21:26:27]

out of 17 reject-version-bit tests ran locally just now, 1 failed @Matt (Dev) [21:36:21] Matt I had proposal regarding website only [21:42:18] Yeah this isn't for the website [21:56:08] So it’s additional?:) [22:00:25] Yeah this is translation for the core wallet [22:12:03]

https://github.com/NAVCoin/navcoin-core/pull/351 [22:27:17]

travis passed @Matt (Dev) @aguycalled [22:32:06] 🎉 [22:38:43] Ok, will make proposal to that as well, next after website [22:50:48] yes! [22:52:25] @aguycalled We're moving on to smoke testing master [22:53:30]

https://pastebin.com/8nNFZnXV @mc290 [22:53:46]

just click clone then extend it if you want to add more [22:54:06]

ill update it as i test [23:25:54] https://github.com/NAVCoin/navcoin-core/pull/352 [23:26:12] oh god Travis is testing my PR [23:26:22] the suspense is killing me