[06:26:35] having my final crack at the code review now [06:26:38] should be done in a bit [08:24:55] @aguycalled approved! [08:25:20] only some minor comments. everything reads well as i understand it [08:25:28] ill leave you to merge the branch when you're happy [09:55:08] @aguycalled looks like https://github.com/navcoin/navcoin-core/pull/634 has 3 approvals, should we merge? [09:56:32] just merged [10:05:25] @aguycalled I've merged master into my GUI branch [10:05:29] And I ran into a conflict [10:05:32] Can you check https://github.com/navcoin/navcoin-core/pull/557/commits/78c6ea49980747620af4c910777a1370a9b22185 [10:05:39] And let me know if I merged it correctly? [10:06:35] I'm re-running the verifychain commands on my branch as well to make sure it does not regress. [10:22:54] the commit looks all right @mxaddict [10:43:06] 👌 [17:08:07] should we cancel pr 642 since it's already in 634? [17:08:12] i think? [18:07:38] im working on the stress script for DAO PR right now. currently working on making node variables dynamic, so that we can have whatever amount of stressing nodes pushing out proposals and votes. https://gist.github.com/chasingkirkjufell/69c06d19c5afe7969692e83afd3322db [18:08:49] and ideally we can create devnet with whatever network configuration we like, say 3 nodes stressing and 2 idle nodes connects to node 1 etc. [20:06:09] @mxaddict how goes the UI stuff? [20:06:34] @aguycalled should I start to put together the next release now this branch is merged? [20:14:54] sure [20:43:19] ill have a look tomorrow at the script @salmonskinroll [20:49:05] sounds good. i haven't started with the DAO stuff yet. so far i just managed to make the node count dynamic. [20:49:47] @prole while you're at it, do you have some time for PR 641 ? https://github.com/navcoin/navcoin-core/pull/641 , im thinking it should be a quick one [20:58:57] Okay sure