[04:58:06] <navcoin-bot> <prole> im doing a full code review of the verifychain branch tonight / tomorrow
[04:58:39] <navcoin-bot> <prole> what else do you guys need me to do here? should i run these scripted tests? or do you have it under control?
[05:05:22] <navcoin-bot> <salmonskinroll> I have 6 nodes running the scripted tests none stop at the moment and they all look good so far. They are on system Ubuntu 18.10 and  19.04.
[05:05:47] <navcoin-bot> <salmonskinroll> And think aguycalled has at least 3 nodes running it on different systems as well.
[05:08:58] <navcoin-bot> <salmonskinroll> Whatever you think is best.
[06:23:59] <navcoin-bot> <prole> okay, i think ill just focus on doing the line by line code review/commentary
[06:24:16] <navcoin-bot> <prole> the functional and rpc test pass for me here
[06:24:33] <navcoin-bot> <prole> what tests are you hammering with the scripts?
[06:38:34] <navcoin-bot> <salmonskinroll> The script is firing up two nodes and then creating proposals and payment requests none stop and voting none stop while checking the cfund statehash is the same on both nodes after reorg after reorg. At the end, it does a verifychain 4 starting from 1 block to all the blocks.
[06:52:06] <navcoin-bot> <salmonskinroll> Here is the link.
[06:52:09] <navcoin-bot> <salmonskinroll> https://gist.github.com/aguycalled/13f362c29ea9c38624e8dd4593bc37f8
[07:02:50] <navcoin-bot> <prole> great, thanks!
[07:03:05] <navcoin-bot> <prole> sorry been awol last while but im trying to get back ontop of all this
[07:03:15] <navcoin-bot> <prole> you guys steaming ahead of me again! nice one 🙂
[07:59:44] <navcoin-bot> <prole> far out there are a lot of changes in here
[08:34:15] <navcoin-bot> <BuckoNZ> I have no idea what you guys are talking about, most of the time. But the team work.and collaboration is great to see.
[08:45:08] <navcoin-bot> <prole> @aguycalled I've reviewed down to the end of cfund.cpp https://github.com/navcoin/navcoin-core/pull/634
[08:46:09] <navcoin-bot> <prole> I'm going to stop now because my brain is cooked from the last couple hours. But im making progress. All your changes look good so far to me, its more Q&A around why things have changed more than anything. Only 1 or 2 instances where I've actually questioned the logic itself
[08:46:20] <navcoin-bot> <prole> I will resume tomorrow and try to get through the second half
[08:46:30] <navcoin-bot> <prole> and follow up on any answers you have to my PR comments
[08:46:31] <navcoin-bot> <prole> 🙂
[09:15:41] <navcoin-bot> <aguycalled> just answered them
[09:17:06] <navcoin-bot> <prole> Will check in the AM
[09:17:18] <navcoin-bot> <prole> I should have this finished tomorrow
[09:17:23] <navcoin-bot> <prole> 🙏
[09:21:29] <navcoin-bot> <aguycalled> @salmonskinroll i think mx is not available currently so we might need your approval for this pull request to get it merged
[18:18:07] <navcoin-bot> <salmonskinroll> Roger that. Will approve it once some more tests finish successfully.