[07:08:38] @prole @aguycalled [07:08:45] Since we got those 2 merged into 4.7.0 [07:09:00] Are we ready to do final review on https://github.com/navcoin/navcoin-core/pull/545 ? [07:09:12] Or we have some other stuff to get done before hand? [08:39:47] nearly there [08:40:47] there's still these two PR's over on my repo [08:40:48] https://github.com/proletesseract/navcoin-core/pull/36 [08:40:52] https://github.com/proletesseract/navcoin-core/pull/35 [08:41:16] what do we need to do with these? are they covered by what is already on navcoin/navcoin-core master? [08:41:22] in regards to the cfund fixes [08:41:26] or something else? [08:42:02] if we can either merge or close these two [08:42:24] then yeah i can merge master down to the PR branch, update the release notes and we can get another RC out there [08:43:47] Not sure, I'll have a quick look [08:45:55] Actually I've already had a look at those, and I approved the PRs [08:46:19] Not 100% sure how to test https://github.com/proletesseract/navcoin-core/pull/36 though [08:46:28] But code changes look good / make sense [08:50:48] i guess run the build with the bash script alex posted to our group chat and just let it run a bunch and make sure the problem doesnt present itself? [08:51:20] I can see https://github.com/navcoin/navcoin-core/pull/586 [08:51:35] this is the same right? but its closed, so i guess we merge the one on my repo [08:52:16] ill see what i can do to test these two and get them merged and do the PR's for the new RC [08:52:29] its not going to be tonight because i have to do the community news [08:52:36] but hopefully tomorrow i can get the RC ready for gitian building [08:52:44] if not, the next day for sure [08:55:03] Not sure [08:55:08] I think that one was not merged [08:55:38] So we need to merge the PR that is on your repo, into 4.7.0-rc branch [08:56:02] Alright, I've been really busy the past week as well [08:56:17] I'm gonna try and bang out some issues once I get free [08:56:28] Been super busy with some PCI compliance shiz 😄 [09:09:06] @n286cpu i havent tested PR#469 on windows, but we should make sure to test it. @mxaddict can you see if you can reproduce the issue on your computer? [09:09:45] @n286cpu I'll see if I can replicate the windows currency issue [09:09:48] we could also ask people to test it using the 4.7.0-rc which will be republished in the next couple of days [09:09:55] I remember I patched it before as it was crashing the wallet on windows [09:10:17] great! [09:10:42] I'll fire up windows ina a few hours and see if I can replicate/fix [09:11:18] This is the PR that fixed the crash on windows [09:11:18] https://github.com/navcoin/navcoin-core/pull/571 [09:11:31] It might be related, not sure as of yet. [17:37:40] @prole [17:37:51] https://cdn.discordapp.com/attachments/416000318149754881/613758675735281674/Screenshot_2019-08-21_at_16.37.08.png [17:38:13] might be better on send just to include NAV/BTC/USD there? [18:22:38] thats fixed on 4.7.0 iirc @mxaddict [18:32:25] @aguycalled yes, the fix for that was already merged.